Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructor delegation is not allowed prior to C++11. #8

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ find_package(catkin REQUIRED COMPONENTS
polled_camera
)

add_definitions(--std=c++11)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is C++11 needed? ROS only supports C++03

There is no guarantee that C++03 and C++11 will stay ABI-compatible. It may break at anytime without prior notice because it only works "by chance" currently.


#Get architecture
set(CMAKE_MODULE_PATH "${CMAKE_MODULE_PATH};${CMAKE_CURRENT_SOURCE_DIR}/cmake")
include(TargetArchitecture)
Expand Down
5 changes: 2 additions & 3 deletions src/avt_vimba_camera.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,7 @@ static const char* State[] = {
"Ok"};


AvtVimbaCamera::AvtVimbaCamera() {
AvtVimbaCamera(ros::this_node::getName().c_str());
AvtVimbaCamera::AvtVimbaCamera() : AvtVimbaCamera(ros::this_node::getName()){
}

AvtVimbaCamera::AvtVimbaCamera(std::string name) {
Expand Down Expand Up @@ -473,7 +472,7 @@ bool AvtVimbaCamera::setFeatureValue(const std::string& feature_str,
if (writable) {
ROS_DEBUG_STREAM("Setting feature " << feature_str << " value " << val);
VmbFeatureDataType data_type;
err == vimba_feature_ptr->GetDataType(data_type);
err = vimba_feature_ptr->GetDataType(data_type);
if (VmbErrorSuccess == err) {
if (data_type == VmbFeatureDataEnum) {
bool available;
Expand Down