-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added unit tests for check_file_exists() and create_link_reference() #37
base: master
Are you sure you want to change the base?
Conversation
… more unit tests described in #32
holy **** that should be it, im an idiot sometimes |
@posiaden123 thank you for your interest and work you've done. I'd love to give you some guidance before I'd merge your changes in. First, please remove the Second, the Lastly, as a general note on test cases. It would be good to test the negative as well. So it would be good to also test inside of your FileExists class a |
@srz2 how exactly do you want me to ingest from the praw.ini.example, should it be |
@posiaden123 As a general note, you should play around with the config parser in general and be familiar with it. Its a very convenient tool to know. Also, I see that you added .idea to the gitignore, but please note that you have to actually remove the .idea files you committed. If you look at the "Files Changed" tab, they are still listed |
Hey @srz2 ! I've worked with unit tests very briefly, but haven't had much experience with them. To the best of my knowledge, I've added the first two tests requested in #32 , but please let me know if I've made a mistake!