Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of four more posters #120

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Addition of four more posters #120

merged 2 commits into from
Oct 17, 2024

Conversation

Tofsel
Copy link

@Tofsel Tofsel commented Oct 15, 2024 •
edited
Loading

About the PR

Changed the poster description from the one I made (HarMoney) just a little bit, and added four more to have more variety into the server. All of them were done by me (Denetth).

Technical details

Added Missing Poster, UNMC Advert and a variation of it, Safety Lizard Poster inspired by some other Safety Moth posters. Also changed the description for HarMoney to be slightly more representative of Harmony Station.

Requirements

Changelog

🆑

  • add: Added missing poster of a well known individual
  • add: Added UNMC ad poster
  • add: Added variation of the same UNMC poster
  • add: Added Safety Lizz poster
  • tweak: Changed HarMoney poster description

Tofsel added 2 commits October 15, 2024 19:28
@Tofsel
Add files via upload
9a085ee 
Signed-off-by: Denetth <117494542+Tofsel@users.noreply.github.com>
@Tofsel
Add files via upload
9c827cc 
Signed-off-by: Denetth <117494542+Tofsel@users.noreply.github.com>
@Tofsel Tofsel changed the title Addition of four more posters (this time will for real) Addition of four more posters (this time will work for real) Oct 15, 2024
@FluffMe FluffMe self-requested a review October 15, 2024 23:45
@github-actions github-actions bot added the S: Needs Review Review is requested label Oct 15, 2024
FluffMe
FluffMe reviewed Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@FluffMe FluffMe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Added screenshots for @KeldWolf final review

Resources/Textures/_Harmony/Structures/Wallmounts/posters.rsi/harmony_poster16_legit.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Resources/Textures/_Harmony/Structures/Wallmounts/posters.rsi/harmony_poster17_legit.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Resources/Textures/_Harmony/Structures/Wallmounts/posters.rsi/harmony_poster19_legit.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Resources/Textures/_Harmony/Structures/Wallmounts/posters.rsi/harmony_poster18_legit.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@FluffMe FluffMe requested a review from KeldWolf October 16, 2024 08:30
@FluffMe
Copy link
Collaborator

FluffMe commented Oct 16, 2024

If anyone merges this besides me, please merge with squash due to non-descriptive commit messages.

@FluffMe FluffMe changed the title Addition of four more posters (this time will work for real) Addition of four more posters Oct 16, 2024
KeldWolf
KeldWolf approved these changes Oct 17, 2024
View reviewed changes
Copy link

@KeldWolf KeldWolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are made in the right places and with #Harmony comments where shared. Looks good. Approved.

@KeldWolf KeldWolf merged commit e3d7479 into ss14-harmony:master Oct 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FluffMe FluffMe FluffMe left review comments

@KeldWolf KeldWolf KeldWolf approved these changes

Assignees
No one assigned
Labels
Changes: No C# Changes: Sprites S: Needs Review Review is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tofsel @FluffMe @KeldWolf