Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DM01 Entryway and deathmatch PROMOD preset #127

Merged
merged 5 commits into from
Oct 30, 2024

Conversation

Unisol
Copy link

@Unisol Unisol commented Oct 19, 2024

Requires space-wizards#31178

About the PR

Added a (second) deathmatch map, based on a classic map from a different age. Added a deathmatch PROMOD preset (dmpm, deathmatchpromod), that works exactly like regular deathmatch but with guns.

Why / Balance

One map is good, more is better. In addition, existing deathmatch map (Meteor Arena) is not very well fit for small arms combat, being designed for melee combat. PROMOD deathmatch is meant to replicate typical firefight that happens in SS14 but in deathmatch sandbox.

Technical details

N/A

Media

dm01-entryway-0

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

N/A

Changelog

🆑

  • add: added deathmatch map DM01 Entryway
  • add: added deathmatch PROMOD preset

@KeldWolf
Copy link

This could be interesting for future Funday Sunday stuff. I can't imagine it facilitate very many players. Curious what others have to say about it.

@Unisol
Copy link
Author

Unisol commented Oct 20, 2024

There's enough spawn points here for about 10 players, but it's hard to say how many can be comfortably packed in here. I'd guess about 5-7 people with guns can fit in this map without overcrowding.

Copy link
Collaborator

@FluffMe FluffMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor request to relocate.

Resources/Prototypes/Maps/arenas.yml Outdated Show resolved Hide resolved
@Unisol
Copy link
Author

Unisol commented Oct 24, 2024

Issues addressed

@github-actions github-actions bot added the S: Merge Conflict Merge conflict detected label Oct 24, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: Unisol <1929445+Unisol@users.noreply.github.com>
@github-actions github-actions bot removed the S: Merge Conflict Merge conflict detected label Oct 24, 2024
@spanky-spanky
Copy link
Collaborator

Looks good, I’ll let Keld make the call to merge if we went this for Sunday Funday stuff but otherwise I approve.

@FluffMe FluffMe dismissed their stale review October 24, 2024 08:39

Changes addressed

@FluffMe FluffMe requested a review from KeldWolf October 24, 2024 08:40
@github-actions github-actions bot added the S: Needs Review Review is requested label Oct 24, 2024
Copy link
Collaborator

@FluffMe FluffMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly admeme, noone objects. Merged

@FluffMe FluffMe merged commit cf3f2f6 into ss14-harmony:master Oct 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants