Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Lobby Track "Rusty Cans (Battle)" #182

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Conversation

spanky-spanky
Copy link
Collaborator

@spanky-spanky spanky-spanky commented Nov 12, 2024

About the PR

Adds new lobby track "Rusty Cans (Battle)," originally composed for FTL Captain's Edition by Aaron Opfer under CC BY-NC-SA 3.0.

Why / Balance

There's interest in custom Harmony lobby music so I am making this to (hopefully) serve as a template for future tracks. This is one of my favorite tracks from FTL Captain's edition and I was able to find the file and attributions in the code for it, and have brought it here. Link to the modpack

Technical details

  • Resources/Audio/_Harmony/Lobby/rustycansbattle.ogg -- New /Lobby folder and audio track inside.
  • Resources/Audio/_Harmony/Lobby/attributions.yml -- Attributions for Harmony lobby tracks.
  • Resources/Prototypes/SoundCollections/lobby.yml -- Adds rustycansbattle.ogg to lobby music track listing.

Media

Youtube link
image

Requirements

Changelog
🆑

  • add: New lobby track, "Rusty Cans (Battle)."

@github-actions github-actions bot added S: Needs Review Review is requested Changes: No C# and removed S: Needs Review Review is requested labels Nov 12, 2024
Copy link

@KeldWolf KeldWolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate this templating for the future as well.

@spanky-spanky
Copy link
Collaborator Author

Waiting for confirmation from FluffMe that the structuring is right.

Copy link
Collaborator

@FluffMe FluffMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit!

@FluffMe
Copy link
Collaborator

FluffMe commented Nov 13, 2024

Added a screeny in lobby to the PR media section

@spanky-spanky spanky-spanky merged commit baedc24 into master Nov 13, 2024
14 checks passed
@FluffMe FluffMe deleted the spanky-lobbymusic branch November 14, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants