RSC rifle crate as cargo purchase

[Unisol]

About the PR

Added RSC Model 1917, a Nanotrasen-approved Great War rifle. Available for purchase for supply department. Packed by senile veteran of six stellar wars who can't quite remember how many rifles and stripper clips should go in one crate; your mileage will vary.

Why / Balance

Syndicate has cheap mass infantry option, and now Nanotrasen does too. Meant to be a cheap way to arm large amounts of people with questionable quality guns. RSC 1917 is mechanically identical to Mosin Nagant.

Crates are can be unlocked using general security or cargo access.

Cost: one crate goes for 2000$, with one rifle costing $400 and one clip costing $5. Anywhere between 2 and 5 rifles per crate, with anywhere between 4 and 42 clips mean that total cost varies between $1020 and $2210. This ensures cargo can't reliably resell these at a profit.

Stripper clips in secfab go for one steel sheet per one clip with five rounds. This is in line with other .30 ammo options, which come out to 0.18 steel per round.

Technical details

Media

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

• add: added RSC Model 1917 for purchase in supply dept
• add: added stripper clips with .30 ammo to security and ammo techfabs, as well as emagged protolathe

[github-actions]

RSI Diff Bot; head commit 1e33821 merging into 3f9d14d
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_Harmony/Objects/Weapons/Guns/Snipers/rsc-m1917.rsi

State	Old	New	Status
base			Added
bolt-open			Added
equipped-BACKPACK			Added
equipped-SUITSTORAGE			Added
inhand-left			Added
inhand-right			Added
wielded-inhand-left			Added
wielded-inhand-right			Added

Edit: diff updated after 1e33821

[DieselMohawk]

Good sprites.

I have no idea if we should reference real world locations and events with this rifle, even the name is a bit too historically accurate for the SS14 vibe, if you get what I mean.

Anyways, good sprites.

[FluffMe]

@Unisol test fail is real

TestSufficientSpaceForEntityStorageFill fails with CrateArmoryRSC storage fill is too large.

[FluffMe]

[FluffMe]

• Test fail should be addressed (if amount of rifles/ammo changes significantly price may need to be reduced).
• Lost comment, while appreciated and agreed with, should be removed.
• Cargo access on the crate will finally prevent slamming it with pickaxe like idiots. But it differs from other gun purchases. If that's an intended change, I agree with this, but please test if it overwrites access: [["Armory"]] of CrateWeaponSecure and if Armory access should be added (maybe instead of security even, who knows. No idea how it works without testing).

Thanks for this addition. Hail Cargonia!
I'll read and test this more thoroughly when changes are addressed.

[FluffMe]

I have no idea if we should reference real world locations and events with this rifle, even the name is a bit too historically accurate for the SS14 vibe, if you get what I mean.

There is a precedent with Mosin, and they have the same vibe IMO.
We also already discussed if the gun is in public domain or not, so this is also not a concern.

[FluffMe]

PS: I especially dig the RNG factor of the crate XD

[Unisol]

Increased CrateArmoryRSC capacity to 50; removed truthful comment; added Armory access to the crate in addition to Supply and Securty.

Changes adressed

[FluffMe]

Another test fail: NoStaticPriceAndStackPrice

[Unisol]

No idea what this is about, I've checked crate, rifle and clip - all have only static price and not stack price.

[FluffMe]

I'll debug when I get some time next week.

[FluffMe]

Was a Heisentest XD

[FluffMe]

Code is good! great job, thank you.

I'll leave it hanging for a bit for admins and Keld to pitch in, since it's a new weapon and weapon source for the crew.

[liltenhead]

Considering there's an AK and a Mosin in game, I like the idea. Sprite is great looking too.