Detective Spriting Update: Searching for Good Drip #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoskiYourk
requested review from
DieselMohawk,
KeldWolf and
FluffMe
as code owners
github-actions
bot
added
Changes: No C#
Changes: Sprites
S: Needs Review
|
RSI Diff Bot; head commit 51be2ee merging into 1401e02 Resources/Textures/_Harmony/Clothing/Head/Hats/brownfedora.rsi
Resources/Textures/_Harmony/Clothing/Head/Hats/greyfedora.rsi
Resources/Textures/_Harmony/Clothing/OuterClothing/Coats/detective.rsi
Resources/Textures/_Harmony/Clothing/OuterClothing/Coats/detective_grey.rsi
|
Can you elaborate? |
I can explain it in DMs if you'd like. |
Signed-off-by: FluffMe <1780586+FluffMe@users.noreply.github.com>
Signed-off-by: FluffMe <1780586+FluffMe@users.noreply.github.com>
FluffMe
approved these changes
Nov 18, 2024
DieselMohawk
approved these changes
Nov 18, 2024
FluffMe
added a commit
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Why / Balance
People have wanted the old sprites updated since they were forcefully merged against community wishes. The original spriter won't let the old sprites be updated, so I've decided to PR it as a Harmony exclusive.
Technical details
_Harmony Namescape
Resources/Textures/_Harmony/Clothing/Head/Hats/brownfedora.rsi -- Brown fedora texture location
Resources/Textures/_Harmony/Clothing/Head/Hats/greyfedora.rsi -- Grey fedora texture location
Resources/Textures/_Harmony/Clothing/OuterClothing/Coats/detective.rsi -- Det coat texture location
Resources/Textures/_Harmony/Clothing/OuterClothing/Coats/detective_grey.rsi -- Grey det coat texture location
Upstream Files
Resources/Prototypes/Entities/Clothing/Head/hats.yml -- Updated fedora sprite pathing
Resources/Prototypes/Entities/Clothing/OuterClothing/coats.yml -- Updating det coat sprite pathing
Media
Requirements
Breaking changes
Changelog
🆑