Update to RSC rifle and RSC rifle crate

[Unisol]

About the PR

Changed texture on bolt-action rifle crate to old wooden texture provided by thesaladmancer. Changed RSC rifle to be stripper-clip fed as opposed to internal magazine fed.

Why / Balance

To further distance RSC from Mosin, RSC now uses stripper clips as magazines and autoejects them when empty (audio for inserting and ejecting clips courtesy Nonagon).

Media

See thread for video presentation of rifle mechanics.

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

• tweak: bolt-action rifle crate received a facelift
• RSC now feeds off stripper clips and ejects empty clips with a very specific PING

[github-actions]

RSI Diff Bot; head commit ed5eb42 merging into f304025
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_Harmony/Structures/Storage/Crates/old_wooden_crate.rsi

State	Old	New	Status
base			Added
closed			Added
icon			Added
locked			Added
open			Added
unlocked			Added
welded			Added

[FluffMe]

@Unisol I've debugged the audio system in RobustToolbox/Robust.Client/Audio/AudioSystem.cs by placing a breakpoint on the line 451 that is in charge of playing an entity if all conditions are correct.

            return PlayEntity(sound, Filter.Local(), source, false, audioParams);

It, as expected, played 3 sounds at the same time: garand-ping-short.wav, garand-ping-rattle.wav, and a sniper.ogg shot sound.

Unless the issue is with misprediction, it's probably a sound overlay issue.
You can attempt adding a quiet time to ping-rattle that is slightly more than ping-short to see if it helps and see if I diagnosed it right.
Feel free to place a breakpoint yourself to monitor what plays and when.

I don't see it as a blocker, so approved.

[Unisol]

You can attempt adding a quiet time to ping-rattle that is slightly more than ping-short to see if it helps

This is how it's been since the very beginning, I had split the ping file into ping and rattle and kept the quiet section in the front of the rattle with the same duration as ping. When I added extra silence at the end of the ping file, double ping became more pronounced, suggesting that it in fact plays twice.

@FluffMe btw, is that issue replicated on your setup at all?

[FluffMe]

You can attempt adding a quiet time to ping-rattle that is slightly more than ping-short to see if it helps

This is how it's been since the very beginning, I had split the ping file into ping and rattle and kept the quiet section in the front of the rattle with the same duration as ping. When I added extra silence at the end of the ping file, double ping became more pronounced, suggesting that it in fact plays twice.

@FluffMe btw, is that issue replicated on your setup at all?

Yeah, Funnily enough i can hear it better if I don't debug it.

sound_debug-2024-11-25_03.35.44.mp4

Sounds are replaced with 2 different debug tones. Rattle one with silence.
First go is not logged, second one logpoint is added.

While playing is called only once, i can still hear artifacts/repetition.

[FluffMe]

Maybe it's just about playing too much stuff at the same time. No idea!

Let me know if you wanna dig into it more, or merge.

[Unisol]

It sounds like an upstream bug, if anything. The only other entity that uses the autoeject feature is the C-20r, and it has very quiet mag eject sound accompanied by a very loud beeping for mag empty sound. It's reasonable to assume it's gone unnoticed so far. In any case, I think it's out of scope for this PR to fix.