Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower max nukie count to 4 #213

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Lower max nukie count to 4 #213

wants to merge 1 commit into from

Conversation

Zap527
Copy link
Collaborator

@Zap527 Zap527 commented Nov 26, 2024

About the PR

Made max nukie count 4 instead of 5

Why / Balance

Putting this up as an option, following admin discussion and community feedback. This is not final. This might not get merged. Only time will tell.
Once again, 100% untested :) Will test once I am on a more stable PC

Changelog
🆑 Jajsha

  • tweak: Lowered nukie max count to 4

@Zap527
Copy link
Collaborator Author

Zap527 commented Nov 26, 2024

Big DNM until we have admin concensus on this.

@Zap527 Zap527 added the S: Awaiting Admin Input Discussion by the admin team is required label Nov 26, 2024
@FluffMe FluffMe marked this pull request as draft November 26, 2024 00:57
@FluffMe FluffMe added DO NOT MERGE and removed S: Needs Review Review is requested labels Nov 26, 2024
@RotEmpress
Copy link

+1, I'm complete fine with this. Nukies steamroll with 5 compared to 4 Nukies (since 5 nukies will always be pulled from total player pop. So it's 5v45 compared to 4v46 Seems more fair, in general and I don't know why we still have five nukies total. Hell, i'm sorta of the opinion it should be 3 nukies, but that's a personal opinion that I am not going to be arguing here in github.

@Zap527
Copy link
Collaborator Author

Zap527 commented Nov 29, 2024

I think this is generally well liked by the admin team, but I don't really know how to test it? I checked that the prototype doesn't brick but I don't know how I'd simulate 50 clients to check that the nukie count is correct.

@FluffMe
Copy link
Collaborator

FluffMe commented Nov 29, 2024

I think this is generally well liked by the admin team, but I don't really know how to test it? I checked that the prototype doesn't brick but I don't know how I'd simulate 50 clients to check that the nukie count is correct.

It's possible to launch multiple clients and connect, and ready up. You just have to change username on each one: JoeGenero1, JoeGenero2, etc. THis will murder your computer, unless it can handle 50 clients, though. So you probably can't.

As an alternative change nukie per crew for test purposes and ready however many clients you can. Or we just trust and test on prod.

@Zap527
Copy link
Collaborator Author

Zap527 commented Nov 29, 2024

Prod tests is always a great idea that will in no way backfire.

@FluffMe
Copy link
Collaborator

FluffMe commented Nov 29, 2024

YOLO

@TheCrimsonJupiter
Copy link

Prod tests is always a great idea that will in no way backfire.

I'm all for the "WE BALL" approach to balancing.

@KeldWolf KeldWolf marked this pull request as ready for review December 2, 2024 16:06
Copy link

@KeldWolf KeldWolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm also on board with this. Nukies on Harmony are good and creative enough.

@FluffMe
Copy link
Collaborator

FluffMe commented Dec 5, 2024

@Zap527 test it in some way, and it's good to go, i guess!

@FluffMe FluffMe marked this pull request as draft December 15, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# DO NOT MERGE S: Awaiting Admin Input Discussion by the admin team is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants