Apply suggestions from code review

Co-authored-by: FluffMe <1780586+FluffMe@users.noreply.github.com> Signed-off-by: TheCrimsonJupiter <54331834+TheCrimsonJupiter@users.noreply.github.com>
ss14-harmony · Dec 9, 2024 · c45699a · c45699a
1 parent 12024e8
commit c45699a
Show file tree

Hide file tree

Showing 9 changed files with 13 additions and 13 deletions.
diff --git a/Resources/Prototypes/Entities/Clothing/Hands/gloves.yml b/Resources/Prototypes/Entities/Clothing/Hands/gloves.yml
@@ -116,9 +116,9 @@
   description: Perfect for dealing with paperwork and matters with bureaucracy.
   components:
   - type: Sprite
-    sprite: _Harmony/Clothing/Hands/Gloves/hop.rsi
+    sprite: _Harmony/Clothing/Hands/Gloves/hop.rsi # Harmony change. Resprite
   - type: Clothing
-    sprite: _Harmony/Clothing/Hands/Gloves/hop.rsi
+    sprite: _Harmony/Clothing/Hands/Gloves/hop.rsi # Harmony change. Resprite
   - type: Fiber
     fiberMaterial: fibers-durathread
     fiberColor: fibers-black

diff --git a/Resources/Prototypes/Entities/Clothing/Head/hats.yml b/Resources/Prototypes/Entities/Clothing/Head/hats.yml
@@ -322,9 +322,9 @@
   description: A grand, stylish head of personnel's cap.
   components:
   - type: Sprite
-    sprite: _Harmony/Clothing/Head/Hats/hopcap.rsi
+    sprite: _Harmony/Clothing/Head/Hats/hopcap.rsi # Harmony change. Resprite
   - type: Clothing
-    sprite: _Harmony/Clothing/Head/Hats/hopcap.rsi
+    sprite: _Harmony/Clothing/Head/Hats/hopcap.rsi # Harmony change. Resprite
   - type: Tag
     tags:
     - ClothMade

diff --git a/Resources/Prototypes/Entities/Clothing/Uniforms/jumpskirts.yml b/Resources/Prototypes/Entities/Clothing/Uniforms/jumpskirts.yml
@@ -170,9 +170,9 @@
   description: Rather bland and inoffensive. Perfect for vanishing off the face of the universe.
   components:
   - type: Sprite
-    sprite: _Harmony/Clothing/Uniforms/Jumpskirt/hop.rsi
+    sprite: _Harmony/Clothing/Uniforms/Jumpskirt/hop.rsi # Harmony change. Resprite
   - type: Clothing
-    sprite: _Harmony/Clothing/Uniforms/Jumpskirt/hop.rsi
+    sprite: _Harmony/Clothing/Uniforms/Jumpskirt/hop.rsi # Harmony change. Resprite
 
 - type: entity
   parent: [ClothingUniformSkirtBase, BaseCommandContraband]

diff --git a/Resources/Prototypes/Entities/Clothing/Uniforms/jumpsuits.yml b/Resources/Prototypes/Entities/Clothing/Uniforms/jumpsuits.yml
@@ -325,9 +325,9 @@
   description: Rather bland and inoffensive. Perfect for vanishing off the face of the universe.
   components:
   - type: Sprite
-    sprite: _Harmony/Clothing/Uniforms/Jumpsuit/hop.rsi
+    sprite: _Harmony/Clothing/Uniforms/Jumpsuit/hop.rsi # Harmony change. Resprite
   - type: Clothing
-    sprite: _Harmony/Clothing/Uniforms/Jumpsuit/hop.rsi
+    sprite: _Harmony/Clothing/Uniforms/Jumpsuit/hop.rsi # Harmony change. Resprite
 
 - type: entity
   parent: [ClothingUniformBase, BaseCommandContraband]

diff --git a/Resources/Textures/_Harmony/Clothing/Head/Hats/hopcap.rsi/meta.json b/Resources/Textures/_Harmony/Clothing/Head/Hats/hopcap.rsi/meta.json
@@ -1,7 +1,7 @@
 {
   "version": 1,
   "license": "CC-BY-SA-3.0",
-  "copyright": "Taken from the tg station atcommithttps://github.com/tgstation/tgstation/commit/4f6190e2895e09116663ef282d3ce1d8b35c032e and then resprited by TadJohnson00 and Timemaster99 for DeltaV atcommithttps://github.com/DeltaV-Station/Delta-v/pull/1501, and then resprited a third time by CrimsonJupiter for Harmony",
+  "copyright": "Taken from the tg station at commit https://github.com/tgstation/tgstation/commit/4f6190e2895e09116663ef282d3ce1d8b35c032e and then resprited by TadJohnson00 and Timemaster99 for DeltaV at commit https://github.com/DeltaV-Station/Delta-v/pull/1501, and then resprited a third time by CrimsonJupiter for Harmony",
   "size": {
     "x": 32,
     "y": 32

diff --git a/Resources/Textures/_Harmony/Clothing/Uniforms/Jumpskirt/hop.rsi/meta.json b/Resources/Textures/_Harmony/Clothing/Uniforms/Jumpskirt/hop.rsi/meta.json
@@ -1,7 +1,7 @@
 {
   "version": 1,
   "license": "CC-BY-SA-3.0",
-  "copyright": "Originally taken from tgstation atcommithttps://github.com/tgstation/tgstation/commit/c838ba21dae97db345e0113f99596decd1d66039 icon, inhand, and equipped resprites by CrimsonJupiter for Harmony.",
+  "copyright": "Originally taken from tgstation at commit https://github.com/tgstation/tgstation/commit/c838ba21dae97db345e0113f99596decd1d66039 icon, inhand, and equipped resprites by CrimsonJupiter for Harmony.",
   "size": {
     "x": 32,
     "y": 32

diff --git a/Resources/Textures/_Harmony/Clothing/Uniforms/Jumpskirt/hopmesskit.rsi/meta.json b/Resources/Textures/_Harmony/Clothing/Uniforms/Jumpskirt/hopmesskit.rsi/meta.json
@@ -1,7 +1,7 @@
 {
   "version": 1,
   "license": "CC-BY-SA-3.0",
-  "copyright": "Made by TadJohnson00 and Timemaster99 for DeltaV atcommithttps://github.com/DeltaV-Station/Delta-v/pull/1501, resprited by CrimsonJupiter for Harmony.",
+  "copyright": "Made by TadJohnson00 and Timemaster99 for DeltaV at commit https://github.com/DeltaV-Station/Delta-v/pull/1501, resprited by CrimsonJupiter for Harmony.",
   "size": {
     "x": 32,
     "y": 32

diff --git a/Resources/Textures/_Harmony/Clothing/Uniforms/Jumpsuit/hop.rsi/meta.json b/Resources/Textures/_Harmony/Clothing/Uniforms/Jumpsuit/hop.rsi/meta.json
@@ -1,7 +1,7 @@
 {
   "version": 1,
   "license": "CC-BY-SA-3.0",
-  "copyright": "Originally taken from tgstation atcommithttps://github.com/tgstation/tgstation/commit/c838ba21dae97db345e0113f99596decd1d66039 icon, inhand, and equipped resprites by CrimsonJupiter for Harmony.",
+  "copyright": "Originally taken from tgstation at commit https://github.com/tgstation/tgstation/commit/c838ba21dae97db345e0113f99596decd1d66039 icon, inhand, and equipped resprites by CrimsonJupiter for Harmony.",
   "size": {
     "x": 32,
     "y": 32

diff --git a/Resources/Textures/_Harmony/Clothing/Uniforms/Jumpsuit/hopmesskit.rsi/meta.json b/Resources/Textures/_Harmony/Clothing/Uniforms/Jumpsuit/hopmesskit.rsi/meta.json
@@ -1,7 +1,7 @@
 {
   "version": 1,
   "license": "CC-BY-SA-3.0",
-  "copyright": "Made by TadJohnson00 and Timemaster99 for DeltaV atcommithttps://github.com/DeltaV-Station/Delta-v/pull/1501, resprited by CrimsonJupiter for Harmony.",
+  "copyright": "Made by TadJohnson00 and Timemaster99 for DeltaV at commit https://github.com/DeltaV-Station/Delta-v/pull/1501, resprited by CrimsonJupiter for Harmony.",
   "size": {
     "x": 32,
     "y": 32