forked from ParadiseSS13/Paradise
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate loot pool for CC #1801
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis PR implements a dedicated Central Command loot pool with infinite available points and defines several tiered loot spawners for Syndicate-themed items. Additionally, it cleans up the Centcomm map by removing redundant, non-movable lockers to prevent duplicate spawns. Updated Class Diagram for Central Command Loot PoolclassDiagram
%% Central Command Loot Pool base class
class CentCommLootPool {
+id: "central_command_spawn_pool"
+available_points: INFINITY
}
%% Loot spawner base class that uses the central loot pool
class CentCommLootSpawner {
+icon: String
+icon_state: String
+spawn_pool_id: "central_command_spawn_pool"
}
%% Syndicate themed spawner tiers extending the loot spawner
class SyndicateTier1 {
+spawn_loot_chance: 40
+loot: List
}
class SyndicateTier2 {
+spawn_loot_chance: 40
+loot: List
}
class SyndicateTier3 {
+spawn_loot_chance: 40
+loot: List
}
class SyndicateTier4 {
+loot: List
}
class SyndicateMixed {
+loot: List (tier weights: tier1=30, tier2=20, tier3=5, tier4=1)
}
%% Relationships
CentCommLootPool <|-- CentCommLootSpawner : uses
CentCommLootSpawner <|-- SyndicateTier1
CentCommLootSpawner <|-- SyndicateTier2
CentCommLootSpawner <|-- SyndicateTier3
CentCommLootSpawner <|-- SyndicateTier4
CentCommLootSpawner <|-- SyndicateMixed
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
m-dzianishchyts
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📜 CL не требуется
Эти изменения не влияют на игровой процесс или игроки по какой-то причине не должны о них знать
🗺️ Изменение Карты
В этом ПРе затронут файл не станционной карты. Может и не один.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что этот PR делает
Добавляет отдельный пул для лута ЦК (Синди ЦК, если быть точнее).
Удаляет лишние шкафы депота (если на ЦК появлялся какой-то лут - спавнилось по два шкафа, оба из которых нельзя передвигать. А если не спавнилось - был один несдвигаемый шкаф).
Почему это хорошо для игры
ЦК - гиммик зона, на которую не должны распространяться рамки "баланса". По этой причине все спавнеры на ней имеют стоимость в 0 очков, а сам пул имеет бесконечное количество очков для траты. Иными словами, можно спавнить что угодно и сколь угодно, не влияя на баланс игроков.
Кол-во очков лута для космоса не трогаю, т.к. в планах ещё сделать отдельный пул для гейтов, и потом уже снизить до 1700 для космоса, как на оффах.
Тестирование
Запустил локалку, лут появился и без лишних шкафов.
Summary by Sourcery
Introduce a separate loot pool for Central Command.
New Features:
Tests: