Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate loot pool for CC #1801

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Conversation

kyunkyunkyun
Copy link

@kyunkyunkyun kyunkyunkyun commented Feb 12, 2025

Что этот PR делает

Добавляет отдельный пул для лута ЦК (Синди ЦК, если быть точнее).

Удаляет лишние шкафы депота (если на ЦК появлялся какой-то лут - спавнилось по два шкафа, оба из которых нельзя передвигать. А если не спавнилось - был один несдвигаемый шкаф).

Почему это хорошо для игры

ЦК - гиммик зона, на которую не должны распространяться рамки "баланса". По этой причине все спавнеры на ней имеют стоимость в 0 очков, а сам пул имеет бесконечное количество очков для траты. Иными словами, можно спавнить что угодно и сколь угодно, не влияя на баланс игроков.

Кол-во очков лута для космоса не трогаю, т.к. в планах ещё сделать отдельный пул для гейтов, и потом уже снизить до 1700 для космоса, как на оффах.

Тестирование

Запустил локалку, лут появился и без лишних шкафов.

Summary by Sourcery

Introduce a separate loot pool for Central Command.

New Features:

  • Added a dedicated loot pool for Central Command with infinite available points, allowing for diverse item spawns without impacting game balance.

Tests:

  • Tested locally to confirm loot appeared correctly.

Copy link

sourcery-ai bot commented Feb 12, 2025

Reviewer's Guide by Sourcery

This PR implements a dedicated Central Command loot pool with infinite available points and defines several tiered loot spawners for Syndicate-themed items. Additionally, it cleans up the Centcomm map by removing redundant, non-movable lockers to prevent duplicate spawns.

Updated Class Diagram for Central Command Loot Pool

classDiagram
    %% Central Command Loot Pool base class
    class CentCommLootPool {
      +id: "central_command_spawn_pool"
      +available_points: INFINITY
    }

    %% Loot spawner base class that uses the central loot pool
    class CentCommLootSpawner {
      +icon: String
      +icon_state: String
      +spawn_pool_id: "central_command_spawn_pool"
    }

    %% Syndicate themed spawner tiers extending the loot spawner
    class SyndicateTier1 {
      +spawn_loot_chance: 40
      +loot: List
    }
    class SyndicateTier2 {
      +spawn_loot_chance: 40
      +loot: List
    }
    class SyndicateTier3 {
      +spawn_loot_chance: 40
      +loot: List
    }
    class SyndicateTier4 {
      +loot: List
    }
    class SyndicateMixed {
      +loot: List (tier weights: tier1=30, tier2=20, tier3=5, tier4=1)
    }

    %% Relationships
    CentCommLootPool <|-- CentCommLootSpawner : uses
    CentCommLootSpawner <|-- SyndicateTier1
    CentCommLootSpawner <|-- SyndicateTier2
    CentCommLootSpawner <|-- SyndicateTier3
    CentCommLootSpawner <|-- SyndicateTier4
    CentCommLootSpawner <|-- SyndicateMixed
Loading

File-Level Changes

Change Details Files
Introduced a dedicated loot pool for Central Command.
  • Created a new spawn pool with infinite available points for CC.
  • Defined multiple tiered spawner objects (tier1, tier2, tier3, tier4) with distinct loot lists and spawn chances.
  • Implemented a mixed tier spawner that combines the chances of individual tiers to diversify loot drops.
modular_ss220/balance/code/loot/pools.dm
Removed redundant lockers in the Centcomm map.
  • Deleted extra, non-movable locker entities from the Centcomm map to avoid duplicate spawns.
_maps/map_files220/generic/centcomm.dmm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the 🗺️ Изменение Карты В этом ПРе затронут файл не станционной карты. Может и не один. label Feb 12, 2025
@ss220app ss220app bot added the 📜 CL невалиден Этот чейнджлог не пройдет валидацию перед публикацией. Исправить или удалить, если не требуется label Feb 12, 2025
@m-dzianishchyts m-dzianishchyts added the 📜 CL не требуется Эти изменения не влияют на игровой процесс или игроки по какой-то причине не должны о них знать label Feb 13, 2025
@ss220app ss220app bot removed the 📜 CL невалиден Этот чейнджлог не пройдет валидацию перед публикацией. Исправить или удалить, если не требуется label Feb 13, 2025
@m-dzianishchyts m-dzianishchyts merged commit e5e768e into ss220club:master Feb 13, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 CL не требуется Эти изменения не влияют на игровой процесс или игроки по какой-то причине не должны о них знать 🗺️ Изменение Карты В этом ПРе затронут файл не станционной карты. Может и не один.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants