Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ModbusManagerInterface refactored to have separate result and failure callbacks #5

Merged
merged 21 commits into from
Jul 6, 2020
Merged

ModbusManagerInterface refactored to have separate result and failure callbacks #5

merged 21 commits into from
Jul 6, 2020

Commits on Jun 29, 2020

  1. [modbus] readcallback changed to nonnull 

    Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>
    @mrbig
    mrbig committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    e45bf0d View commit details
    Browse the repository at this point in the history

  2. [modbus] Refactored ModbusCommunicationInterface to have seperate cal… 

    …lback for result and failure

However I had to dig deep to reach all the affected parts.
Also there is a new callback, and a new "result" type to communicate
the failures.

Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>
    @mrbig
    mrbig committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    21cc56d View commit details
    Browse the repository at this point in the history

  3. [modbus] SmokeTest refactored to new api 

    Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>
    @mrbig
    mrbig committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    c352e0a View commit details
    Browse the repository at this point in the history

  4. [modbus] Modbus bundle refactored to use the new api 

    Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>
    @mrbig
    mrbig committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    52d9656 View commit details
    Browse the repository at this point in the history

  5. [modbus][sunspec] refactored sunspec bundle to use the new modbus API 

    Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>
    @mrbig
    mrbig committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    e3243b0 View commit details
    Browse the repository at this point in the history

  6. [modbus] refactor modbus tests to use the new api 

    Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>
    @mrbig
    mrbig committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    e8fdd97 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2020

  1. [modbus] Removed ModbusWriteCallback interface from ModbusDataThingHa… 

    …ndler

Also reset ModbusDataThingHandler testWriteHandling generic to it's original form


Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>
    @mrbig
    mrbig committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    59169d7 View commit details
    Browse the repository at this point in the history

  2. [modbus] ModbusDataThingHandler does not implement ModbusReadCallback… 

    … anymore

Instead it has a public onReadResult method. ModbusPollerThingHandler changed to
work with ModbusDataThingHandler children.

Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>
    @mrbig
    mrbig committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    acfb9b5 View commit details
    Browse the repository at this point in the history

  3. [modbus] Fixed caching in ModbusPollerThingHandler 

    Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>
    @mrbig
    mrbig committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    66225e8 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2020

  1. [modbus] read modbus data as Optionals 

    Signed-off-by: Sami Salonen <ssalonen@gmail.com>
    @ssalonen
    ssalonen committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    2c47b06 View commit details
    Browse the repository at this point in the history

  2. [modbus] toString for PollResult 

    Signed-off-by: Sami Salonen <ssalonen@gmail.com>
    @ssalonen
    ssalonen committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    72da757 View commit details
    Browse the repository at this point in the history

  3. [modbus] fixed confusing variable name 

    Signed-off-by: Sami Salonen <ssalonen@gmail.com>
    @ssalonen
    ssalonen committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    357783a View commit details
    Browse the repository at this point in the history

  4. [modbus] Disallow null callbacks 

    Signed-off-by: Sami Salonen <ssalonen@gmail.com>
    @ssalonen
    ssalonen committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    fae05a2 View commit details
    Browse the repository at this point in the history

  5. [modbus] mvn spotless:apply 

    Signed-off-by: Sami Salonen <ssalonen@gmail.com>
    @ssalonen
    ssalonen committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    1d90e50 View commit details
    Browse the repository at this point in the history

  6. [modbus] Removing Nullable decorations 

    Signed-off-by: Sami Salonen <ssalonen@gmail.com>
    @ssalonen
    ssalonen committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    4ce384b View commit details
    Browse the repository at this point in the history

  7. [modbus] submitOneTimeWrite simplification 

    Signed-off-by: Sami Salonen <ssalonen@gmail.com>
    @ssalonen
    ssalonen committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    8eb186d View commit details
    Browse the repository at this point in the history

  8. [modbus] Less verbose logging 

    Signed-off-by: Sami Salonen <ssalonen@gmail.com>
    @ssalonen
    ssalonen committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    e61a970 View commit details
    Browse the repository at this point in the history

  9. [modbus] submitOneTimePoll simplification 

    Signed-off-by: Sami Salonen <ssalonen@gmail.com>
    @ssalonen
    ssalonen committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    67f8eca View commit details
    Browse the repository at this point in the history

  10. [modbus] Less verbose logging 

    Signed-off-by: Sami Salonen <ssalonen@gmail.com>
    @ssalonen
    ssalonen committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    5599748 View commit details
    Browse the repository at this point in the history

  11. [modbus] Many null warnings removed 

    Signed-off-by: Sami Salonen <ssalonen@gmail.com>
    @ssalonen
    ssalonen committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    d77d8fc View commit details
    Browse the repository at this point in the history

  12. [modbus] Fix: no need for a @nonnull annotation because it is default 

    Signed-off-by: Sami Salonen <ssalonen@gmail.com>
    @ssalonen
    ssalonen committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    e9a658f View commit details
    Browse the repository at this point in the history