[3.1.0] Add deck style for ReactSwing #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quead
force-pushed
the
master
branch
3 times, most recently
from
76867cc
to
9bbf74b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've really liked this package and I've started to use for a personal project unfortunately I wanted a different view for the cards so I've created this PR with a different view for cards.
I've created an example page exactly as you've done for the default, the new style it looks like this.
The differences are not huge, I've added to accept a new prop
stackStylewhich defaults to default if is not passed, I've added a switch in render which accepts an enumReactSwingStackStyle.In the example I've used
style-loader&css-loaderas I found easier for me to change it while I was developing.I've updated Readme as well.
That's pretty much what I've done.