Exercise parsers: fixed filename issue when opening files with spaces…

… or umlauts
ssaring · Jul 9, 2023 · d95b176 · d95b176
1 parent d6afbbb
commit d95b176
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 7 deletions.
diff --git a/sportstracker/docs/CHANGES.txt b/sportstracker/docs/CHANGES.txt
@@ -35,6 +35,8 @@ v8.0.0:
  ExerciseViewer changes:
  - Garmin FIT parser: bugfix for handling laps without any speed data
    (when the lap contains just a break without any activity)
+ - All XML-based parsers (GPX, TCX, Polar): fixed error when opening files with
+   spaces or special characters in the filename
 
 v7.9.1:
  Project changes:

diff --git a/sportstracker/docs/TODO.txt b/sportstracker/docs/TODO.txt
@@ -1,9 +1,6 @@
 SportsTracker-TODO
 ==================
 
-Bug: exception when opening or importing HRM files with "Umlauts" in the pathname (at least in macOS):
-- java.net.MalformedURLException: no protocol: /Users/stefan/Desktop/Jörg/2023-06-30 Rambin.gpx
-
 Remove all interfaces which are not really needed and don't provide advantages (e.g. STDocument etc.)
 
 ExerciseViewer standalone mode:

diff --git a/st-exerciseviewer/src/main/kotlin/de/saring/exerciseviewer/parser/impl/GarminTcxParser.kt b/st-exerciseviewer/src/main/kotlin/de/saring/exerciseviewer/parser/impl/GarminTcxParser.kt
@@ -39,7 +39,8 @@ class GarminTcxParser : AbstractExerciseParser() {
     fun parseExercise(filename: String): EVExercise {
 
         try {
-            val document = SAXBuilder().build(filename)
+            // create a File of the filename string to avoid URL problems when filename contains spaces or umlauts
+            val document = SAXBuilder().build(java.io.File(filename))
             return parseExerciseElement(document.rootElement)
         }
         catch (e: Exception) {

diff --git a/st-exerciseviewer/src/main/kotlin/de/saring/exerciseviewer/parser/impl/PolarPedParser.kt b/st-exerciseviewer/src/main/kotlin/de/saring/exerciseviewer/parser/impl/PolarPedParser.kt
@@ -45,7 +45,8 @@ class PolarPedParser : AbstractExerciseParser() {
 
     private fun readPedFile(filename: String): Element {
         try {
-            val document = SAXBuilder().build(filename)
+            // create a File of the filename string to avoid URL problems when filename contains spaces or umlauts
+            val document = SAXBuilder().build(java.io.File(filename))
             return document.rootElement
         } catch (e: Exception) {
             throw EVException("Failed to parse the Polar Personal Trainer exercise file '$filename' ...", e)

diff --git a/st-exerciseviewer/src/main/kotlin/de/saring/exerciseviewer/parser/impl/PolarRS200SDParser.kt b/st-exerciseviewer/src/main/kotlin/de/saring/exerciseviewer/parser/impl/PolarRS200SDParser.kt
@@ -26,7 +26,8 @@ class PolarRS200SDParser : AbstractExerciseParser() {
     fun parseExercise(filename: String): EVExercise {
 
         try {
-            val document = SAXBuilder().build(filename)
+            // create a File of the filename string to avoid URL problems when filename contains spaces or umlauts
+            val document = SAXBuilder().build(java.io.File(filename))
             return parseExerciseElement(document.rootElement)
         }
         catch (e: Exception) {

diff --git a/...xerciseviewer/src/main/kotlin/de/saring/exerciseviewer/parser/impl/TopoGrafixGpxParser.kt b/...xerciseviewer/src/main/kotlin/de/saring/exerciseviewer/parser/impl/TopoGrafixGpxParser.kt
@@ -40,7 +40,8 @@ class TopoGrafixGpxParser : AbstractExerciseParser() {
     fun parseExercise(filename: String): EVExercise {
 
         try {
-            val document = SAXBuilder().build(filename)
+            // create a File of the filename string to avoid URL problems when filename contains spaces or umlauts
+            val document = SAXBuilder().build(java.io.File(filename))
             return parseExerciseElement(document.rootElement)
         }
         catch (e: Exception) {