Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database model for privacy modes #12

Closed
staltz opened this issue Feb 10, 2021 · 3 comments · Fixed by #100
Closed

Database model for privacy modes #12

staltz opened this issue Feb 10, 2021 · 3 comments · Fixed by #100
Labels
Go golang related stuff

Comments

@staltz
Copy link
Member

staltz commented Feb 10, 2021

No description provided.

@cryptix
Copy link
Member

cryptix commented Feb 16, 2021

A bit meta but I'm having trouble making up my mind about this: I'm contested between have a separate config file that needs to be set before starting the server and putting it on a single row config table that can be changed from the web UI.

I see being able to change from the frontend both as problem and feature here. Like, the HTTPS hostname is something we probably need before we could even show a first-use setup wizard.

Also only being able to change it through the UI might also turn into a problem.

@cryptix
Copy link
Member

cryptix commented Feb 16, 2021

We at least need to be careful not to mix deployment configuration with room configuration.

If we advise for restoring from backup by just saving the roomdb, changing the hostname of your room might turn into a problem.

@staltz
Copy link
Member Author

staltz commented Feb 16, 2021

Hmm, I understand some of the problems you described, like the backup issue, but what's the connection between a privacy mode and the HTTPS hostname? Ideally it would be best that the privacy mode can be changed after deployment.

Or is the problem the choice of the default privacy mode?

@cryptix cryptix added the Go golang related stuff label Mar 11, 2021
@cryptix cryptix mentioned this issue Mar 23, 2021
14 tasks
@staltz staltz linked a pull request Apr 6, 2021 that will close this issue
2 tasks
@staltz staltz mentioned this issue Apr 6, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Go golang related stuff
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants