Implement Room Privacy Modes #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptix
reviewed
Mar 25, 2021
cryptix
reviewed
Mar 25, 2021
cryptix
requested changes
Mar 26, 2021
| @@ -70,6 +74,23 @@ func (h *Handler) endpoints(_ context.Context, req *muxrpc.Request, snk *muxrpc. | |||
| return err | |||
| } | |||
|
|
|||
| // cblgh: | |||
| // * reject if key in deny list / DeniedKeysService | |||
There was a problem hiding this comment.
the DeniedKeysService lookup needs to be added to roomsrv/init_network.go, not here.
I agree that endpoints is a confusion name, it's really just potentiall endpoints and tangentiall to the actual connection building.
There was a problem hiding this comment.
yeah i know, this is just a note to use it + remember what the service was called
edit: oh wait, maybe i misunderstood actually, hm. i'll have a look inside roomsrv/init_network.go!
cblgh
force-pushed
the
privacy-modes
branch
2 times, most recently
from
502f130 to
377dc79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tracks the progress of implementing support for the SSB Rooms 2 concept of Privacy Modes.
The privacy modes control which types of users are allowed to perform certain actions, such as creating invites. In the open mode, any person may visit the room and create an invite to it. In the restricted mode, only existing room members with the roles of admin or moderator may invite new users.
Privacy modes:
Closes #96
Outstanding todos:
index.htmlif mode is open?)