Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new muxrpc namespace room.* and soft deprecate tunnel.* #89

Closed
8 tasks done
staltz opened this issue Mar 17, 2021 · 8 comments
Closed
8 tasks done

Use new muxrpc namespace room.* and soft deprecate tunnel.* #89

staltz opened this issue Mar 17, 2021 · 8 comments
Assignees
@staltz @cryptix
Labels
Go golang related stuff
Milestone
Community launch

Comments

@staltz
Copy link
Member

staltz commented Mar 17, 2021 •
edited
Loading

@staltz staltz added the Go golang related stuff label Mar 17, 2021
@staltz
Copy link
Member Author

staltz commented Mar 23, 2021

tunnel.endpoints alternative

Ideas:

  • room.crowd
  • room.attendance
  • room.attendants (my favorite)
  • room.audience
  • room.assemblage

@staltz staltz mentioned this issue Mar 26, 2021
Merged
2 tasks
@cryptix
Copy link
Member

cryptix commented Mar 29, 2021

room.attendants 👍 (had to look it up but contrary to my thoughts it translates to the german term for the right concept)

@cryptix cryptix mentioned this issue Mar 29, 2021
Closed
@staltz staltz added this to the Community launch milestone Apr 21, 2021
@staltz staltz mentioned this issue Apr 21, 2021
Closed
cryptix added a commit that referenced this issue May 17, 2021
@cryptix
add room.attendants implementation
e7c20bc 
updates #89
@cryptix cryptix mentioned this issue May 17, 2021
Merged
@staltz
Copy link
Member Author

staltz commented May 19, 2021

Mark tunnel.isRoom as deprecated but keep it working

is this done?

@cryptix
Copy link
Member

cryptix commented May 20, 2021

See #220 (comment).

I wasn't sure if those deprecation comments were meant for the JS side. There isn't really a defined way to do deprecation in Go. You usually just remove the APIS from the next major version.

@staltz
Copy link
Member Author

staltz commented May 20, 2021

@cryptix does attendants include the client's ID too? It seems like it doesn't? That's fine if it's the case, it's just different from tunnel.endpoints and I'd need to know (also to update the spec).

@cryptix
Copy link
Member

cryptix commented May 20, 2021

Sorry, I'm not following. Is the client the joining/parting room member or the room or..?

@staltz
Copy link
Member Author

staltz commented May 20, 2021

When Alice connects to the room and calls the room.attendants() stream, she gets {type: "state", ids: [BOB, CARLA]} not {type: "state", ids: [ALICE, BOB, CARLA]}.

cryptix added a commit that referenced this issue May 21, 2021
@cryptix
remove room.announce and room.leave from muxrpc
d584ff9 
those were confusion and implied some use beyond just opening
tunnel.endpoints/room.attendants (which implicitly does what
tunnel.announce does).

updates #89
@cryptix cryptix mentioned this issue May 21, 2021
Merged
cryptix added a commit that referenced this issue May 21, 2021
@cryptix
remove room.announce and room.leave from muxrpc (#223)
85ee99a 
* remove room.announce and room.leave from muxrpc

those were confusion and implied some use beyond just opening
tunnel.endpoints/room.attendants (which implicitly does what
tunnel.announce does).

updates #89
@staltz
Copy link
Member Author

staltz commented May 25, 2021

spec update: ssbc/rooms2#43

@staltz staltz closed this as completed May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staltz staltz

@cryptix cryptix

Labels
Go golang related stuff
Projects
None yet
Milestone
Community launch
Development

No branches or pull requests
2 participants
@staltz @cryptix