Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registerAlias should return wildcard subdomain URL #160

Closed
staltz opened this issue Apr 16, 2021 · 2 comments
Closed

registerAlias should return wildcard subdomain URL #160

staltz opened this issue Apr 16, 2021 · 2 comments
Labels
Bug Something isn't working Go golang related stuff

Comments

@staltz
Copy link
Member

staltz commented Apr 16, 2021

Tangentially related to #152, we need the Go server itself to understand that wildcard subdomains are enabled, because room.registerAlias should return the alias URL in the format of alice.room.com if wildcard subdomains are used by the room.

A bare minimum solution is to have a CLI argument like -wildcardaliases which then informs the implementation that it can concatenate Alias.Name with h.roomDomain to create alice.room.com, instead of router.CompleteAliasResolve.

But we can consider other more elegant solutions.

The importance of room.registerAlias returning the subdomain is that this will be used by client applications to publish an about msg on SSB self-declaring their alias URL. Client apps can't independently guess what their alias URL is (concatenating the input name plus the multiserver address's host part) because not all rooms will support subdomains, so instead of the client apps doing guess work, the muxrpc should answer what is the truth.

@staltz staltz added Bug Something isn't working Go golang related stuff labels Apr 16, 2021
@staltz staltz added this to the NGIp milestone milestone Apr 16, 2021
@cryptix
Copy link
Member

cryptix commented Apr 19, 2021

But we can consider other more elegant solutions.

I'd say we should have this on the settings page just like the default language. I'd just wait for #143 to go through first while I lay some groundwork in #162.

@staltz
Copy link
Member Author

staltz commented Apr 19, 2021

@cryptix Yes, Settings page would be decent for this!

@cryptix cryptix mentioned this issue Apr 19, 2021
14 tasks
cryptix added a commit that referenced this issue Apr 19, 2021
cblgh added a commit that referenced this issue Apr 19, 2021
cblgh added a commit that referenced this issue Apr 20, 2021
related to #160, requested by cryptix
cblgh added a commit that referenced this issue Apr 20, 2021
related to #160, requested by cryptix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Go golang related stuff
Projects
None yet
Development

No branches or pull requests

2 participants