-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go side of sign-in with ssb #90
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00a1550
to
baae250
Compare
baae250
to
e5d981c
Compare
e5d981c
to
880e560
Compare
staltz
reviewed
Mar 22, 2021
staltz
reviewed
Mar 22, 2021
staltz
reviewed
Mar 22, 2021
staltz
reviewed
Mar 22, 2021
staltz
reviewed
Mar 22, 2021
5bdc985
to
58a6f13
Compare
58a6f13
to
02a11c3
Compare
staltz
reviewed
Mar 24, 2021
7c47462
to
0ce0f6b
Compare
I think I saw a couple "challange" lying around waiting to be massaged. 😺 |
47b634a
to
c624dc5
Compare
staltz
reviewed
Mar 25, 2021
9a7c94d
to
32739c7
Compare
* sketch session store * use session store and unify authentication handling * sketch muxrpc handlers
* fill in sid and sc * fix logout * cascade member removal * fix links * trim suffix from signature * fix /sse/login link * fix sse links and filenames * fix logout * fix typos * fix test compilation * fix bridge test * correct alias url test * add some comments * fix potentiall "can't send" deadlock on bridge some documentation and license headers
* redirect and save the cookie * supress a warning and redirect immediatly
* add test for sse login * add test for invalid solution
these timeouts affect server-sent events, too and interfer with sign-in with ssb.
32739c7
to
1dd3f28
Compare
staltz
reviewed
Mar 26, 2021
staltz
reviewed
Mar 26, 2021
staltz
reviewed
Mar 26, 2021
staltz
reviewed
Mar 26, 2021
staltz
reviewed
Mar 26, 2021
staltz
approved these changes
Mar 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few optional suggestions, but good to merge :)
change variable declaration in login-events.js to const Co-authored-by: André Staltz <andre@staltz.com>
* fix auth test * fix notices test and parallelize * cleanup unused input lookup
60840b4
to
f96b916
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now based on #91, which should be merged first!Done!/auth/withssb/login
endpoint (url subject to change to conform with the spec)fixes #11