-
Notifications
You must be signed in to change notification settings - Fork 333
Conversation
Brought up by [@kas](@RuNxm8SRujPcJx6GjtTQHp6hprAFv5voEkcvoAkB8Pk=.ed25519) in [`%j0/mywlnDar3HJ6ED34ICxzyep3QhM0hvi1ov12A04s=.sha256`](https://ssb.muchmuch.coffee/%25j0%2FmywlnDar3HJ6ED34ICxzyep3QhM0hvi1ov12A04s%3D.sha256). This shows the timestamp of the last message received from a feed.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@christianbundy what's happening up there? 👆 |
okay nevermind seems to have been a github page refresh problem... 🤔 |
Damn it. I was testing out an app and gave it permission to look at my repos, I didn't consent to it spamming a bunch of bullshit on every pull request. Sorry about that, I'm reporting the spam and blocking the service from my account. |
Can we have a screenshot? (reviewing from a distance :D ) And I'm a bit with hoodownr's worry (if I remember the thread correctly) about staring at timestamps. How granular is the timestamp atm? |
This is using moment-timezone so it will show "relevant" timestamps like "1 sec ago" or "5 hours ago". |
Looks great to me, thanks for this patch! I'd be happy to merge any improvements if anyone wants something different. |
I can understand that you want to merge improvements sooner rather than later Christian. But I don't understand why you merged this already, we were just in the middle of a discussion on whether this was overall harmful for patchwork users. I can see how this can get healthy with some more work but atm I'd vote for reverting this. |
Sorry, it wasn't clear to me that you had a blocking concern. If you propose a revert I'd be happy to merge that. |
Follow-up pr if people are curious #1290 |
Brought up by @kas in
%j0/mywlnDar3HJ6ED34ICxzyep3QhM0hvi1ov12A04s=.sha256
. This shows the timestamp of the last message received from a feed.Not sure thought if I did this the right way, depject is still quite the mystery to me...
I think I got the data out of sbot the right way, but not about whether I hooked it up to mutant correctly.
Also not sure about the positioning in the profile view. I put it below the avatar. Always felt like that space was very empty, and this seems to fit in the quite nicely.
Anyhow, another learning experience :P