Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Show last feed activity in profile #1289

Merged
merged 2 commits into from
May 12, 2020
Merged

Show last feed activity in profile #1289

merged 2 commits into from
May 12, 2020

Conversation

black-puppydog
Copy link
Contributor

Brought up by @kas in %j0/mywlnDar3HJ6ED34ICxzyep3QhM0hvi1ov12A04s=.sha256. This shows the timestamp of the last message received from a feed.

Not sure thought if I did this the right way, depject is still quite the mystery to me...
I think I got the data out of sbot the right way, but not about whether I hooked it up to mutant correctly.

Also not sure about the positioning in the profile view. I put it below the avatar. Always felt like that space was very empty, and this seems to fit in the quite nicely.
Anyhow, another learning experience :P

Brought up by [@kas](@RuNxm8SRujPcJx6GjtTQHp6hprAFv5voEkcvoAkB8Pk=.ed25519)
in [`%j0/mywlnDar3HJ6ED34ICxzyep3QhM0hvi1ov12A04s=.sha256`](https://ssb.muchmuch.coffee/%25j0%2FmywlnDar3HJ6ED34ICxzyep3QhM0hvi1ov12A04s%3D.sha256).
This shows the timestamp of the last message received from a feed.
@sonarcloud
Copy link

sonarcloud bot commented May 10, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@black-puppydog
Copy link
Contributor Author

@christianbundy what's happening up there? 👆
I was expecting Travis, but instead I got this sonarcloud thingy that doesn't seem to really run our code, and which thinks we have 0% code duplication, which I find hard to believe.

@black-puppydog
Copy link
Contributor Author

okay nevermind seems to have been a github page refresh problem... 🤔

@christianbundy
Copy link
Contributor

Damn it. I was testing out an app and gave it permission to look at my repos, I didn't consent to it spamming a bunch of bullshit on every pull request. Sorry about that, I'm reporting the spam and blocking the service from my account.

@Powersource
Copy link
Contributor

Can we have a screenshot? (reviewing from a distance :D )

And I'm a bit with hoodownr's worry (if I remember the thread correctly) about staring at timestamps. How granular is the timestamp atm?

@black-puppydog
Copy link
Contributor Author

image
I just put it down there under the profile picture. Not sure it's the best place, honestly, but I didn't want to make the profile page even longer, pushing the feed contents further down. Not married to this placement though.

This is using moment-timezone so it will show "relevant" timestamps like "1 sec ago" or "5 hours ago".
So yes, I can see that concern. I'll have a look into that.

@christianbundy christianbundy merged commit 97ebcff into master May 12, 2020
@christianbundy
Copy link
Contributor

Looks great to me, thanks for this patch! I'd be happy to merge any improvements if anyone wants something different.

@Powersource
Copy link
Contributor

I can understand that you want to merge improvements sooner rather than later Christian. But I don't understand why you merged this already, we were just in the middle of a discussion on whether this was overall harmful for patchwork users.

I can see how this can get healthy with some more work but atm I'd vote for reverting this.

@christianbundy
Copy link
Contributor

Sorry, it wasn't clear to me that you had a blocking concern. If you propose a revert I'd be happy to merge that.

@Powersource
Copy link
Contributor

Follow-up pr if people are curious #1290

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants