Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Add new SKU T1 Mellanox-SN5600-C224O8 #1

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

sschlafman
Copy link
Owner

@sschlafman sschlafman commented Oct 15, 2024

Why I did it

Adding T1 SKU to SN5600

Work item tracking
  • Microsoft ADO (number only):

How I did it

Sku definition doc attached

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Copy link

@stephenxs stephenxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments left for pg profile lookup.
buffer pool sizes should be updated accordingly.

@sschlafman
Copy link
Owner Author

Attaching the SKU definition do
SN5600 C224O8 T1 SKU Template_v2 (Oct 2 2024).docx

Copy link

@stephenxs stephenxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The size of egress_lossless_pool should be the maximum physical memory size exposed to software.
The size of ingress_lossless_pool should be based on calculation.

{% set default_cable = '250m' %}
{% set ingress_lossless_pool_size = '158229504' %}
{% set ingress_lossless_pool_xoff = '19062784' %}
{% set egress_lossless_pool_size = '113722368' %}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% set egress_lossless_pool_size = '113722368' %}
{% set egress_lossless_pool_size = '158229504' %}

limitations under the License.
#}
{% set default_cable = '250m' %}
{% set ingress_lossless_pool_size = '158229504' %}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% set ingress_lossless_pool_size = '158229504' %}
{% set ingress_lossless_pool_size = '113722368' %}

limitations under the License.
#}
{% set default_cable = '40m' %}
{% set ingress_lossless_pool_size = '158229504' %}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% set ingress_lossless_pool_size = '158229504' %}
{% set ingress_lossless_pool_size = '113722368' %}

{% set default_cable = '40m' %}
{% set ingress_lossless_pool_size = '158229504' %}
{% set ingress_lossless_pool_xoff = '19062784' %}
{% set egress_lossless_pool_size = '113722368' %}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% set egress_lossless_pool_size = '113722368' %}
{% set egress_lossless_pool_size = '158229504' %}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants