-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox] Add new SKU T1 Mellanox-SN5600-C224O8 #1
base: master
Are you sure you want to change the base?
Conversation
a0958f1
to
303d65d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments left for pg profile lookup.
buffer pool sizes should be updated accordingly.
device/mellanox/x86_64-nvidia_sn5600-r0/Mellanox-SN5600-C224O8/pg_profile_lookup.ini
Outdated
Show resolved
Hide resolved
Attaching the SKU definition do |
changed cable length to 250m to match SKU definition
813b537
to
a89130e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The size of egress_lossless_pool
should be the maximum physical memory size exposed to software.
The size of ingress_lossless_pool
should be based on calculation.
{% set default_cable = '250m' %} | ||
{% set ingress_lossless_pool_size = '158229504' %} | ||
{% set ingress_lossless_pool_xoff = '19062784' %} | ||
{% set egress_lossless_pool_size = '113722368' %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{% set egress_lossless_pool_size = '113722368' %} | |
{% set egress_lossless_pool_size = '158229504' %} |
limitations under the License. | ||
#} | ||
{% set default_cable = '250m' %} | ||
{% set ingress_lossless_pool_size = '158229504' %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{% set ingress_lossless_pool_size = '158229504' %} | |
{% set ingress_lossless_pool_size = '113722368' %} |
limitations under the License. | ||
#} | ||
{% set default_cable = '40m' %} | ||
{% set ingress_lossless_pool_size = '158229504' %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{% set ingress_lossless_pool_size = '158229504' %} | |
{% set ingress_lossless_pool_size = '113722368' %} |
{% set default_cable = '40m' %} | ||
{% set ingress_lossless_pool_size = '158229504' %} | ||
{% set ingress_lossless_pool_xoff = '19062784' %} | ||
{% set egress_lossless_pool_size = '113722368' %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{% set egress_lossless_pool_size = '113722368' %} | |
{% set egress_lossless_pool_size = '158229504' %} |
Why I did it
Adding T1 SKU to SN5600
Work item tracking
How I did it
Sku definition doc attached
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)