Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in admin translation editing #207

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

lkeegan
Copy link
Member

@lkeegan lkeegan commented Dec 13, 2024

  • ensure that all sections from de are present in each translation
  • if a section is missing then add it
  • we don't need to add missing keys as they are created automatically
  • resolves Admin translation broken #206

- ensure that all sections from de are present in each translation
- if a section is missing then add it
- we don't need to add missing keys as they are created automatically
- resolves #206
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 34.23%. Comparing base (f847c70) to head (67e3ae8).

Files with missing lines Patch % Lines
...ntend/src/lib/components/Admin/Translations.svelte 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
- Coverage   34.27%   34.23%   -0.05%     
==========================================
  Files         109      109              
  Lines        3778     3783       +5     
  Branches       94       94              
==========================================
  Hits         1295     1295              
- Misses       2404     2409       +5     
  Partials       79       79              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkeegan lkeegan merged commit e594e1b into main Dec 13, 2024
7 checks passed
@lkeegan lkeegan deleted the fix_206_admin_translations_bug branch December 13, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin translation broken
2 participants