Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor the making stats text function #252

Merged
merged 5 commits into from
Oct 2, 2023
Merged

refactor the making stats text function #252

merged 5 commits into from
Oct 2, 2023

Conversation

ZoeJacky
Copy link
Collaborator

@ZoeJacky ZoeJacky commented Oct 2, 2023

No description provided.

@ZoeJacky ZoeJacky requested a review from lkeegan October 2, 2023 09:35
@ZoeJacky ZoeJacky temporarily deployed to release October 2, 2023 14:23 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 2, 2023 •
edited
Loading

Codecov Report

Merging #252 (d433112) into main (216984d) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
- Coverage   89.93%   89.82%   -0.11%     
==========================================
  Files          19       19              
  Lines        1589     1573      -16     
==========================================
- Hits         1429     1413      -16     
  Misses        160      160
Files Coverage Δ
src/vstt/vis.py 95.14% <100.00%> (-0.35%) ⬇️

@ZoeJacky ZoeJacky temporarily deployed to release October 2, 2023 15:01 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

lkeegan
lkeegan approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@lkeegan lkeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ZoeJacky ZoeJacky merged commit daacd30 into main Oct 2, 2023
16 checks passed
@ZoeJacky ZoeJacky deleted the refactor_statistics_formatting branch October 2, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkeegan lkeegan lkeegan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZoeJacky @lkeegan