Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict the value of 2 variables "window-length" and "polyorder" in the example, set the numpy version < 2.0.0 in pyproject.toml #277

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

ZoeJacky
Copy link
Collaborator

  1. Restrict the value of 2 variables "window-length" and "polyorder" in the example;
  2. Set the numpy version < 2.0.0 in pyproject.toml

Copy link
Member

@lkeegan lkeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to add ipywidgets to the docs optional dependencies in pyprojec.toml to fix the readethedocs build, otherwise looks good to me!

Copy link

sonarqubecloud bot commented Sep 3, 2024

Copy link
Member

@lkeegan lkeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ZoeJacky ZoeJacky merged commit 9b3a6d6 into main Sep 3, 2024
15 of 16 checks passed
@ZoeJacky ZoeJacky deleted the restrict_window_length_and_polyorder branch September 3, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants