Reorganize trial conditions and display settings #285
Conversation
|
| if not dialog.OK: | ||
| return None | ||
| dialog = TreeDialog(trial) | ||
| if dialog.exec_() == QDialog.Accepted: |
There was a problem hiding this comment.
| if dialog.exec_() == QDialog.Accepted: | |
| if dialog.exec() == QDialog.Accepted: |
| @@ -3,9 +3,11 @@ | |||
| from typing import Callable | |||
|
|
|||
| from psychopy.visual.window import Window | |||
| from PyQt5.QtGui import QFont | |||
There was a problem hiding this comment.
If you use qtpy here instead of PyQt5 then it also works with PyQt6, pyside, etc
| child_item = QtWidgets.QTreeWidgetItem(parent_item) | ||
| checkbox = QtWidgets.QCheckBox(f"{labels[key]}") | ||
| tree_widget.setItemWidget(child_item, 0, checkbox) | ||
| checkbox.clicked.connect(self._update_value_callback(key)) | ||
| self._widgets[key] = checkbox |
There was a problem hiding this comment.
this code is copy&pasted below so maybe it could be a function?
| tree_widget.setItemWidget(item, 0, checkbox) | ||
| checkbox.clicked.connect(self._update_value_callback(key)) | ||
| self._widgets[key] = checkbox | ||
|
|
||
| self.setLayout(outer_layout) |
There was a problem hiding this comment.
see https://github.com/ssciwr/vstt/blob/main/tests/test_display_widget.py for the existing tests of this widget as an example of how to test these gui elements
Note these tests still pass even though you changed this widget, as they iterate over the checkboxes in the display so are not affected by the checkboxes now being inside a treewidget, but maybe you could add something there to check that the tree widget has the expected groups?
No description provided.