Skip to content
This repository was archived by the owner on Feb 14, 2025. It is now read-only.

Preparing for v0.4.0 release. #77

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

tdenewiler
Copy link
Collaborator

  • Marking package as deprecated.
  • All plugins moved to main statick package.
  • Pinned statick dependency to lower than v0.12 to avoid module collisions.

- Marking package as deprecated.
- All plugins moved to main `statick` package.
- Pinned `statick` dependency to lower than v0.12 to avoid module
  collisions.
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.01%. Comparing base (fad823c) to head (13ef92b).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #77       +/-   ##
===========================================
- Coverage   97.46%   29.01%   -68.45%     
===========================================
  Files           7        6        -1     
  Lines         276      224       -52     
===========================================
- Hits          269       65      -204     
- Misses          7      159      +152     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdenewiler tdenewiler requested a review from xydesa February 7, 2025 16:15
@xydesa
Copy link
Collaborator

xydesa commented Feb 10, 2025

Is the plan for all these projects to do 1 last release, then "archive" the project in PyPI and github?
https://blog.pypi.org/posts/2025-01-30-archival/

should we also do something like this? https://dev.to/hckjck/python-deprecation-2mof#:~:text=%3D2)-,Package%20deprecation,-Package%20deprecation%20works

@tdenewiler
Copy link
Collaborator Author

tdenewiler commented Feb 10, 2025

Is the plan for all these projects to do 1 last release, then "archive" the project in PyPI and github? https://blog.pypi.org/posts/2025-01-30-archival/

should we also do something like this? https://dev.to/hckjck/python-deprecation-2mof#:~:text=%3D2)-,Package%20deprecation,-Package%20deprecation%20works

That is my plan. I like the deprecation warning. We don't have __init__.py files at the package level though. I'll try adding one with the deprecation warning. If it doesn't work quickly, I'm okay leaving the PRs as-is. Archiving on PyPI and GitHub should be sufficient.

@tdenewiler
Copy link
Collaborator Author

tdenewiler commented Feb 13, 2025

We can't add __init__.py because we are using the same directory/package structure in the main repo and in the plugin repos. If we did add __init__.py that file would get installed and overwrite the __init__.py from the main repo, and that would trigger a deprecation warning for the main repo/package. That is not the outcome we are looking for.

The alternative is to add the deprecation warning per module. But, there are quite a few (dozens) in the plugin repos. I don't want to go in and make all those changes for repos that are getting archived (I'm against it for time reasons, I'm not against it technically if someone else wants to do that work).

I recommend we move forward with the Deprecated section at the top of the README in each plugin repo, and archiving the projects on GitHub and PyPI.

@denewiler denewiler merged commit 971a0d0 into sscpac:main Feb 14, 2025
27 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants