Remove setting package file_type as a boolean in ROS discovery plugin. #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Add required PyPI dependencies for building ROS1 packages.
Codecov Report
@@ Coverage Diff @@
## main #439 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 56 57 +1
Lines 3269 3286 +17
=========================================
+ Hits 3269 3286 +17
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
xydesa
reviewed
Jul 26, 2022
tests/plugins/discovery/ros_discovery_plugin/test_ros_discovery_plugin.py
Show resolved
Hide resolved
tests/plugins/discovery/ros_discovery_plugin/test_ros_discovery_plugin.py
Show resolved
Hide resolved
tests/plugins/discovery/ros_discovery_plugin/test_ros_discovery_plugin.py
Show resolved
Hide resolved
tests/plugins/discovery/ros_discovery_plugin/test_ros_discovery_plugin.py
Show resolved
Hide resolved
tests/plugins/discovery/ros_discovery_plugin/test_ros_discovery_plugin.py
Show resolved
Hide resolved
… to install dependencies for their packages.
Co-authored-by: Alexander Xydes <alexander.l.xydes.civ@us.navy.mil>
tdenewiler
changed the title
xydesa
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.