feat: explicitly specify containerPort in helm chart #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifying the containerPort, on the one hand, has a documentary purpose, by making explicit which ports are exposed by the container. On the other hand, it permits the usage of other tools that rely on the containerPort, like PodMonitors from the prometheus operator. Fix #1305
phbelitz
force-pushed
the
feat/container-port
branch
from
cccfaca
to
8547459
Compare
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1308 +/- ##
========================================
Coverage 96.58% 96.58%
========================================
Files 23 23
Lines 1319 1319
========================================
Hits 1274 1274
Misses 45 45 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying the containerPort, on the one hand, has a documentary purpose, by making explicit which ports are exposed by the container. On the other hand, it permits the usage of other tools that rely on the containerPort, like PodMonitors from the prometheus operator.
Fix #1305
duplicated from #1306 because of pipeline issue with external PRs
Checklist
developChart.yaml(if necessary)