Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RuntimeError #1334

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Fix RuntimeError #1334

merged 2 commits into from
Nov 2, 2023

Conversation

Starkteetje
Copy link
Member

@Starkteetje Starkteetje commented Oct 26, 2023

We fail sometimes like here with RuntimeError: Timeout context manager should be used inside a task, which this PR fixes.

Description

Using the default initialization of the event loop (i.e. not doing it ourselves) seems to fix the problem (locally ran into RuntimeErrors 5/20 complexity integration tests before and 0/20 after fix)

Checklist

  • PR is rebased to/aimed at branch develop
  • PR follows Contributing Guide
  • Added tests (if necessary)
  • Extended README/Documentation (if necessary)
  • Adjusted versions of image and Helm chart in Chart.yaml (if necessary)

@Starkteetje Starkteetje changed the base branch from master to develop October 26, 2023 15:18
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c75fba4) 96.58% compared to head (6bc1318) 96.59%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1334   +/-   ##
========================================
  Coverage    96.58%   96.59%           
========================================
  Files           23       23           
  Lines         1319     1320    +1     
========================================
+ Hits          1274     1275    +1     
  Misses          45       45           
Files Coverage Δ
connaisseur/flask_application.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Starkteetje Starkteetje marked this pull request as ready for review November 1, 2023 12:47
@Starkteetje Starkteetje merged commit ecc08d0 into develop Nov 2, 2023
50 checks passed
@Starkteetje Starkteetje deleted the asyncio-loop branch November 2, 2023 11:56
@Starkteetje Starkteetje mentioned this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants