Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: new testimages #1484

Merged
merged 2 commits into from
Jan 30, 2024
Merged

ci: new testimages #1484

merged 2 commits into from
Jan 30, 2024

Conversation

phbelitz
Copy link
Member

@phbelitz phbelitz commented Jan 30, 2024

Because of expired signature data, new signatures needed to be created. At the same time we decided to minimize the size of our testimages.

  • PR is rebased to/aimed at branch develop
  • PR follows Contributing Guide
  • Added tests (if necessary)
  • Extended README/Documentation (if necessary)
  • Adjusted versions of image and Helm chart in Chart.yaml (if necessary)

tests/testimages/double_sig/Dockerfile Fixed Show fixed Hide fixed
tests/testimages/signed/Dockerfile Fixed Show fixed Hide fixed
tests/testimages/special_sig/Dockerfile Fixed Show fixed Hide fixed
tests/testimages/unsigned/Dockerfile Fixed Show fixed Hide fixed
tests/testimages/wrong_signer/Dockerfile Fixed Show fixed Hide fixed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2117da1) 96.39% compared to head (36a8396) 96.39%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1484   +/-   ##
========================================
  Coverage    96.39%   96.39%           
========================================
  Files           23       23           
  Lines         1359     1359           
========================================
  Hits          1310     1310           
  Misses          49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Because of expired signature data, new signatures needed to be created. At the same time we decided to minimize the size of our testimages.
@phbelitz phbelitz merged commit 3715bef into develop Jan 30, 2024
52 checks passed
@phbelitz phbelitz deleted the ci/new-testimages branch January 30, 2024 14:04
@phbelitz phbelitz mentioned this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants