fix: Fix handling of undefined values in values.yaml #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phbelitz
reviewed
May 10, 2024
Before this commit, there were different cases where Connaisseur mishandled default values in its config, if their parent keys were not set in the values.yaml. Resulting errors could've been anything between inconsequential (additional log entry) and fatal (e.g. missing deployment of Role). This commit fixes handling of these values.
Starkteetje
force-pushed
the
fix-unset-config-values-handling
branch
from
4b621d8
to
97483f7
Compare
phbelitz
approved these changes
May 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this commit, there were different cases where Connaisseur mishandled default values in its config, if their parent keys were not set in the values.yaml. Resulting errors could've been anything between inconsequential (additional log entry) and fatal (e.g. missing deployment of Role). This commit fixes handling of these values.
Checklist
developChart.yaml(if necessary)