testing #1716
Merged
testing #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1716 +/- ##
===========================================
+ Coverage 84.00% 91.26% +7.25%
===========================================
Files 42 35 -7
Lines 2939 2530 -409
===========================================
- Hits 2469 2309 -160
+ Misses 404 170 -234
+ Partials 66 51 -15 ☔ View full report in Codecov by Sentry. |
Starkteetje
reviewed
Aug 2, 2024
phbelitz
force-pushed
the
test/integration/fix-workload
branch
from
d094769
to
de863a2
Compare
The workload test tried to test a StatefulSet workload, which in case tried to claim a volume. To do so it tried to startup another pod which Connaisseur would block, because of the deny all default policy. The workload test was now decoupled from the preconfig test so that it gets their own custom policy in which the extra pod is allowed. Also some refactoring on the waiting of readiness for workloads.
phbelitz
force-pushed
the
test/integration/fix-workload
branch
from
de863a2
to
f1e02d1
Compare
Starkteetje
approved these changes
Aug 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the potentially flakey workload test 🤷
Checklist
developChart.yaml(if necessary)