-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: key interface #540
feat: key interface #540
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some first minor comments
f62128b
to
14dddd0
Compare
Codecov Report
@@ Coverage Diff @@
## develop #540 +/- ##
===========================================
+ Coverage 96.69% 96.80% +0.10%
===========================================
Files 22 22
Lines 1179 1219 +40
===========================================
+ Hits 1140 1180 +40
Misses 39 39
Continue to review full report at Codecov.
|
14dddd0
to
74e2542
Compare
52d247d
to
a82ce30
Compare
a82ce30
to
953e66e
Compare
7e72026
to
0fb556a
Compare
321fb01
to
43f1d64
Compare
43f1d64
to
771bc49
Compare
This commit adds an easy way to add additional key types into connaisseur. The first set of supported keys are: ECDSA, RSA[cosign], KMS[cosign] and Keyless[cosign] ande each gets automatically recognized.
ec7e1d9
to
85a398b
Compare
This commit adds an easy way to add additional key types into connaisseur. The first set of supported keys are: ECDSA, RSA[cosign], KMS[cosign] and Keyless[cosign] ande each gets automatically recognized.
Description
We eventually want to support more types of keys and even apply additional logic to specific types, while also have a common interface so that the types can be easily exchanged.
Checklist
develop
values.yaml
andChart.yaml
(if necessary)