Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: key interface #540

Merged
merged 1 commit into from
Apr 29, 2022
Merged

feat: key interface #540

merged 1 commit into from
Apr 29, 2022

Conversation

phbelitz
Copy link
Member

@phbelitz phbelitz commented Feb 11, 2022

This commit adds an easy way to add additional key types into connaisseur. The first set of supported keys are: ECDSA, RSA[cosign], KMS[cosign] and Keyless[cosign] ande each gets automatically recognized.

Description

We eventually want to support more types of keys and even apply additional logic to specific types, while also have a common interface so that the types can be easily exchanged.

Checklist

  • PR is rebased to/aimed at branch develop
  • PR follows Contributing Guide
  • Added tests (if necessary)
  • Extended README/Documentation (if necessary)
  • Adjusted versions of image and Helm chart in values.yaml and Chart.yaml (if necessary)

Copy link
Collaborator

@xopham xopham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some first minor comments

connaisseur/keys.py Outdated Show resolved Hide resolved
connaisseur/validators/cosign/cosign_validator.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2022

Codecov Report

Merging #540 (321fb01) into develop (21232a2) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #540      +/-   ##
===========================================
+ Coverage    96.69%   96.80%   +0.10%     
===========================================
  Files           22       22              
  Lines         1179     1219      +40     
===========================================
+ Hits          1140     1180      +40     
  Misses          39       39              
Impacted Files Coverage Δ
connaisseur/exceptions.py 100.00% <100.00%> (ø)
connaisseur/trust_root.py 100.00% <100.00%> (ø)
connaisseur/validators/cosign/cosign_validator.py 99.24% <100.00%> (-0.04%) ⬇️
connaisseur/validators/notaryv1/key_store.py 100.00% <100.00%> (ø)
connaisseur/validators/notaryv1/notary.py 98.33% <100.00%> (ø)
...naisseur/validators/notaryv1/notaryv1_validator.py 98.31% <100.00%> (+0.01%) ⬆️
connaisseur/validators/notaryv1/trust_data.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21232a2...321fb01. Read the comment docs.

connaisseur/keys.py Outdated Show resolved Hide resolved
connaisseur/keys.py Outdated Show resolved Hide resolved
connaisseur/keys.py Outdated Show resolved Hide resolved
connaisseur/keys.py Outdated Show resolved Hide resolved
connaisseur/keys.py Outdated Show resolved Hide resolved
connaisseur/keys.py Outdated Show resolved Hide resolved
connaisseur/keys.py Outdated Show resolved Hide resolved
connaisseur/keys.py Outdated Show resolved Hide resolved
connaisseur/keys.py Outdated Show resolved Hide resolved
connaisseur/keys.py Outdated Show resolved Hide resolved
connaisseur/validators/cosign/cosign_validator.py Outdated Show resolved Hide resolved
connaisseur/validators/cosign/cosign_validator.py Outdated Show resolved Hide resolved
connaisseur/validators/cosign/cosign_validator.py Outdated Show resolved Hide resolved
connaisseur/keys.py Outdated Show resolved Hide resolved
@phbelitz phbelitz force-pushed the feat/key-interface branch 2 times, most recently from 52d247d to a82ce30 Compare April 1, 2022 08:41
connaisseur/keys.py Outdated Show resolved Hide resolved
connaisseur/keys.py Outdated Show resolved Hide resolved
connaisseur/keys.py Outdated Show resolved Hide resolved
connaisseur/keys.py Outdated Show resolved Hide resolved
connaisseur/keys.py Outdated Show resolved Hide resolved
connaisseur/keys.py Outdated Show resolved Hide resolved
connaisseur/validators/cosign/cosign_validator.py Outdated Show resolved Hide resolved
connaisseur/validators/notaryv1/trust_data.py Outdated Show resolved Hide resolved
connaisseur/validators/notaryv1/trust_data.py Show resolved Hide resolved
connaisseur/trust_root.py Outdated Show resolved Hide resolved
connaisseur/keys.py Outdated Show resolved Hide resolved
connaisseur/trust_root.py Outdated Show resolved Hide resolved
connaisseur/trust_root.py Outdated Show resolved Hide resolved
connaisseur/trust_root.py Outdated Show resolved Hide resolved
connaisseur/trust_root.py Outdated Show resolved Hide resolved
connaisseur/validators/cosign/cosign_validator.py Outdated Show resolved Hide resolved
connaisseur/validators/cosign/cosign_validator.py Outdated Show resolved Hide resolved
connaisseur/validators/cosign/cosign_validator.py Outdated Show resolved Hide resolved
connaisseur/validators/cosign/cosign_validator.py Outdated Show resolved Hide resolved
connaisseur/validators/cosign/cosign_validator.py Outdated Show resolved Hide resolved
connaisseur/trust_root.py Outdated Show resolved Hide resolved
This commit adds an easy way to add additional key types into connaisseur. The first set of supported keys are: ECDSA, RSA[cosign], KMS[cosign] and Keyless[cosign] ande each gets automatically recognized.
@phbelitz phbelitz merged commit 85a398b into develop Apr 29, 2022
@phbelitz phbelitz deleted the feat/key-interface branch April 29, 2022 14:17
@xopham xopham mentioned this pull request May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants