Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MAME support #1

Closed
sgtstadanko opened this issue Dec 8, 2014 · 11 comments
Closed

Add MAME support #1

sgtstadanko opened this issue Dec 8, 2014 · 11 comments
Assignees

Comments

@sgtstadanko
Copy link

Hey. Great utility! I have used this on my retropie to scrape my snes and 2600 roms flawlessly. I am having issues with mame roms. It fails on all of them either on the hash check with gamesdb or "no valid roms found in this zip" Not sure if this is a file name structure issue and a romset issue. It looks like from the error that scraper is actually looking in the zip file for data. all the mame roms are 0.37b5. Here is a snippet of the errors:

2014/12/08 17:21:13 INFO: Starting: dkong.zip
2014/12/08 17:21:13 ERR: error processing dkong.zip: No valid roms found in zip.

Any ideas? Worked great on snes and 2600 roms.

@sselph
Copy link
Owner

sselph commented Dec 8, 2014

I haven't added MAME support yet so the script is looking for Megadrive roms that are zipped. I am in the process of adding support for MAME, but there are tons of games and I haven't had a ton of time to work on it in the past few weeks. MAME seems to have a well defined file naming so I will add support to notice the expected file names and match to the correct metadata.

@sgtstadanko
Copy link
Author

Rad! Thanks for the quick reply. I have tons of mame roms if you need
testing help.
On Dec 8, 2014 5:34 PM, "Steven Selph" notifications@github.com wrote:

I haven't added MAME support yet so the script is looking for Megadrive
roms that are zipped. I am in the process of adding support for MAME, but
there are tons of games and I haven't had a ton of time to work on it in
the past few weeks. MAME seems to have a well defined file naming so I will
add support to notice the expected file names and match to the correct
metadata.


Reply to this email directly or view it on GitHub
#1 (comment).

@sselph sselph self-assigned this Dec 8, 2014
@sselph sselph changed the title error on mame roms Add MAME support Dec 9, 2014
@rodrigosiviero
Copy link

@sgtstadanko I've managed to get 2.138 images from the mam4all working set(2.270 roms) here:

http://www.gotmame.com/files/snap/< filename >.png

just use clrmamepro with mame4all dat file get the game list then do some script to get the files from the website, that was the cheap solution for me.

(Emumovies has around 1.800 imgs only)

@sselph
Copy link
Owner

sselph commented Jan 13, 2015

Yeah getting the mapping of filename, human readable name, image seems like it could be done fairly easily and this might be a good start. I think people would like to have the full set of metadata like thegamesdb has so maybe pull from that when available then fallback to the basic name, image when it isn't.

@rodrigosiviero
Copy link

@sselph yeah, would be awesome to have all metadata for MAME/FBA

@sselph
Copy link
Owner

sselph commented Jan 20, 2015

I've added a mame scraper that is pulling from mamedb. @sgtstadanko let me know how that works.

@sselph
Copy link
Owner

sselph commented Jan 20, 2015

Forgot to mention you have to provide the -mame flag to trigger the new logic.

@sgtstadanko
Copy link
Author

thanks! Ran it remotely and terminal results look good. Will check UI when I get home.

@sselph sselph closed this as completed Jan 25, 2015
@kcgen
Copy link

kcgen commented Nov 3, 2016

@sgtstadanko, @sselph - does the -mame flag need anything special?
I'm using the master sselph branch (as o this comment) to scrape the mame roms in my mame-libretro, fba, and neogeo folders (all zips freshly deposited by clrmamepro), and the scraper reports hash not found for all the zips.
This happens regardless if I use the -mame flag or not.

@MichaelRPowell
Copy link

@krcroft sounds like an improper match for what is in the database.

Which romset did you build with clrmamepro?

@ifdiaz
Copy link

ifdiaz commented Dec 7, 2017

Hash not found error for all the mame/fba games. It only works on older versions of the sript (maybe because uses different database?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants