Feature Request: Desky | Support Height Decoder Variant

[OkhammahkO]

Pasted from our discord chat. Let me know if you need any more info.

We’ve come across a desk which appears to be slightly different in one area.

In summary (and to refresh)...
Most desks send:

• This protocol over the RJ45 port. Bytes 3 and 4 (of 4) are used for height. We use this in your component.
  https://discord.com/channels/429907082951524364/952464939480645642/957101799528095774
• This protocol over the R12 port (for Bluetooth dongle port), and bytes 5 and 6 (of 9) are used for height. This is not used by the desky component.
  https://discord.com/channels/429907082951524364/952464939480645642/957107106492850246

But what we’ve found with some Jarvis desks is that they appear to actually send the second “9 byte message” over the RJ45 port. Everything else appears to be the same (including how the bytes are used to calculate height.
https://community.home-assistant.io/t/desky-standing-desk-esphome-works-with-desky-uplift-jiecang-assmann-others/383790/105?u=mahko_mahko

So I think the feature request is to be able to select/switch the protocol.
My thought was the revised config might look a bit like below?

Thank you!

desky:
  #uart_id: desk_uart  (optional, unless multiple uarts are defined)
  id: my_desky
  height_protocol_variant: (optional, 4byte or 9byte, defaults to 4byte)
  height:  # optional sensor publishing the current height
    name: Desk Height
    # any other sensor options

[hraschan]

Hello @ssieb,

I stumbled across the HA project. I’m one of those users who would need this improvement. Would be amazing to add a second variant vor 9byte. I posted all my infos here:

https://community.home-assistant.io/t/desky-standing-desk-esphome-works-with-desky-uplift-jiecang-assmann-others/383790/296?u=hraschan

I will also look into your code. Maybe I’m able to implement it myself.

Greetings,
Max

[ssieb]

Any idea what the other bytes of the message are for?

[hraschan]

Not really. I actually really new to this topic. Maybe the display? My display is black when requesting the height. I only can confirm that 5 and 6 is necessary for calculating the heigh. At least for this desk.

[hraschan]

I looked into your code. Not really familiar with cpp.

Are you combining byte 3 and 4 to calculate the height in the following part?

 while (this->available()) {
    uint8_t c;
    int value;
    this->read_byte(&c);
    switch (state) {
     case 0:
      if (c == 1)
	state = 1;
      break;
     case 1:
      if (c == 1)
	state = 2;
      else
	state = 0;
      break;
     case 2:
      high_byte = c;
      state = 3;
      break;
     case 3:
      value = (high_byte << 8) + c;
      if (this->current_pos_ != value) {
        this->current_pos_ = value;
        if (this->height_sensor_ != nullptr)
          this->height_sensor_->publish_state(value);
      }
      state = 0;
      break;
    }
  }```

[OkhammahkO]

Any idea what the other bytes of the message are for?

Similar to the most common protocol, I don''t think we ever decoded all bytes.

Interesting some controllers (like mine) appear to use the "common protocol" on the rj45 port and the "Other protocol" on the rj12 port. On some controllers that rj12 port is for a bluetooth dongle.
But on other controllers they appear to just use the "other protocol" on the rj45 port.

https://community.home-assistant.io/t/desky-standing-desk-esphome-works-with-desky-uplift-jiecang-assmann-others/383790/23?u=mahko_mahko

[hraschan]

Is there an easy way to add the "Other protocol" config?

[OkhammahkO]

Is there an easy way to add the "Other protocol" config?

That's part of the suggested feature request... So not yet.

[ssieb]

ok, it should now auto-detect and use the correct protocol.

[OkhammahkO]

Auto detect!! Classic ssieb... Over achieving on the solution!😜

@hraschan can you please report back here and on the HA thread with how you go with testing?

I might be able to help out a bit with minor config/hardware issues...

[hraschan]

Omg wow. Thats amazing. I will try that later and let you know.

[hraschan]

@ssieb I tried it at my desk. i get a value in home assistant. But its way off maybe the calculation is wrong?

[10:55:55][D][uart_debug:176]: <<< 242,242,1,3,2,230,15,251,126
[10:55:55][D][uart_debug:176]: <<< 242,242,1,3,2,230,15,251,126

Byte 5 and 6
2*256 +230 = 742mm

409.1mm in Home Assistant

on more information. When i move up the desk the height in home assistant is decreasing instead of increasing. Also the "Desky is moving" value is always off.

[OkhammahkO]

Are you using just the basic config @hraschan ? Best to start with that if not.

Maybe share your config as next step.

https://github.com/ssieb/esphome_components/blob/master/components%2Fdesky%2FREADME.md

Can you confirm that the 742mm value you manually calculated from the log is consistent with what's shown on the desk display?

[hraschan]

Yea 742 is the value my desk is showing.

[10:55:55][D][uart_debug:176]: <<< 242,242,1,3,2,230,15,251,126
When calulating byte 7 and 8 then i get the value above:

15, 251

15*256 + 251 = 4091mm => 409.1cm

So the calculation is off. I'm using the config from Mahko_Mahko

        if (this->rx_data_.size() < 7)
          continue;
        value = (this->rx_data_[4] << 8) + this->rx_data_[5];

But this code looks fine to me. Doesn't it?

[OkhammahkO]

Cool let's see what ssieb reckons.

Btw I'm Mahko_Mahko;)

I use a more customised config.

But probably ssieb will find it easier to debug using his intended / designed config.

[hraschan]

Ohhh hahah. Sorry man. I didn't read your name correctly. If @ssieb is requesting his config I can try any time.