Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge branch 'main' of https://github.com/ssitu/ComfyUI_fabric #12

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Merge branch 'main' of https://github.com/ssitu/ComfyUI_fabric #12

merged 2 commits into from
Oct 17, 2023

Conversation

chrisgoringe
Copy link
Contributor

@chrisgoringe chrisgoringe commented Oct 16, 2023

To resolve #11

@ssitu
Copy link
Owner

ssitu commented Oct 17, 2023

image

@ssitu
Copy link
Owner

ssitu commented Oct 17, 2023

I think you have to change the required inputs to optional and set the defaults for latent1 and latent2 = None
Also, that'll mean adding a check for the case when both inputs are None, so maybe raise an error when that happens.

@chrisgoringe
Copy link
Contributor Author

The specific use case I was working on was when there is a connection, but the upstream node sends None as an output. This happens with the Image Chooser Fabric node when no image is selected.

Can't see much point supporting the case where there is literally no Comfy connection - just remove the node!

If both inputs are None, it will output None, which seems like correct behaviour - give downstream nodes the option of how they deal.

@ssitu
Copy link
Owner

ssitu commented Oct 17, 2023

Oh okay I see. I thought this was a UX thing.

@ssitu ssitu merged commit 3782eca into ssitu:main Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow None as input to LatentBatch
2 participants