-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include doc and manpage in Debian package. #112
base: master
Are you sure you want to change the base?
Include doc and manpage in Debian package. #112
Conversation
I've been meaning to go through and put together an There is already one for the docs at I'm on a bit of an odd schedule right now and need to get to sleep, but, tomorrow, I'll start looking into what the best way is to reconcile the convention of having an (Maybe I could put together something which runs Sphinx's |
Add... - A unified "Authors" page at the end of the HTML manual - An AUTHORS file in the root of the project - A script to generate AUTHORS from the ReST sources - A section on AUTHORS in the developer's guide - An "et al" to the site footer that should have been there since the beginning (Thanks to PR #112 for reminding me to do this.)
Done.
That (The HTML version needed to be |
Oops. Almost forgot about a couple of credits for people whose names don't show up in Fixed. |
This implies building HTML doc and therefore adds python3-sphinx as a build-time dependency.
2d93702
to
00af923
Compare
Great! I rebased the branch of the PR. What version number do you want? I guess 0.4.0gtk3 is no longer relevant. 0.4.0? 0.4.1? |
In the short term, I'd prefer whatever this command outputs so the package name agrees with ./setup.py --version (I haven't bumped it from 0.4.0 to 0.4.1 yet because there have been no changes to the code yet... just to the site/documentation.) In the long term, I'll want to try to reduce the amount of changelog duplication too. |
Makes sense.
Agreed. DRY principle. Some projects maintain a "short" changelog, concise, no details, and a "long" changelog. Git history feels like a long changelog anyway. |
The first thing I'd want to do is check whether there's a Debian policy on the matter before making a decision, then let that inform my decision on which choice to unify both on.
My git history would be a very long changelog, so definitely not that. I was thinking more of how to minimize duplication between the |
…ws to build on recent Debian.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of things that look questionable to me, but thanks for the work. I've been meaning to get back to work on QuickTile but I've been bogged down preparing the house for winter for a while.
(And, prior to that, the year has just been a mess for me. I didn't start to get productive on non-essentials until two months ago.)
|
||
EOF | ||
|
||
set -euo pipefail | ||
|
||
cd "$(dirname "$(readlink -f "$0")" )" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a specific example of why this change is necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh. I'm not used to GitHub's reviews. I'll have to remember to mark the last line rather than the first next time.
bash recompile_local_debian_package.sh --install-deps-only | ||
USER=$(id -un) ; userdel \"\$USER\" | ||
GID=$(id -g) ; groupadd -f -g \$GID $(id -gn) | ||
useradd -u $(id -u) --gid stephane -l -m \"\$USER\" -s /bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may be stephane
, but I'm ssokolow
and have no such user and group on my system. It looks like you're either missing username and group lookups here or should use names that make it more clear that all that matters is matching the external UID and GID.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! Of course this is unacceptable for published software. Probably a local expedient that I forgot to refine.
Fixes failure to compile on Debian 12.
@ssokolow this follows your request on #106 .
How about some credits in the documentation?
Hints from git history. What do you think?