Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command: smarttile #96

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

pogobanane
Copy link

adds 4 new commands to commands.py for window smart window tiling:

Move and resize windows to the known positions left, top-left, top... for example via the arrow keys.
Shove a window further against the border of your screen to cycle through the window sizes.

@coveralls
Copy link

coveralls commented Jul 3, 2018

Coverage Status

Coverage decreased (-0.4%) to 33.147% when pulling b6d5596 on pogobanane:master into 06c4b03 on ssokolow:master.

@ssokolow
Copy link
Owner

ssokolow commented Jul 3, 2018

Hmm. A cursory examination of this looks like it's trying to implement part of what #10 is supposed to enable more universally.

I really need to try harder to make time to get back to clearing out the open issues on this.

@pogobanane
Copy link
Author

this does not implement dynamic window movement/resizeing but utilizes the existing commands for 'top-left', 'top', 'top-right', 'left'...

Instead this breaks the 9 commands down to 4 (upwards, downwards, left-wards, right-wards). You basically use those 4 direction commands to navigate through a virtual 3x3 grid of those 9 commands.

@ssokolow
Copy link
Owner

ssokolow commented Jul 3, 2018

Yes, and the underlying goal of #10 is to rebase all of QuickTile's internals on such a virtual grid to solve a bunch of tricky problems and make it more versatile.

@pogobanane
Copy link
Author

You talk about replacing the simple 'left', 'top-left', 'top', 'top-right' commands by a scalable, more versatile, grid based approach?

i think this project should support both: the simple commands which will be enough for a simple minded person with an full hd screen - and the more complex and powerful commands for advanced users.

@ssokolow
Copy link
Owner

ssokolow commented Jul 4, 2018

No need to worry. I don't intend to remove any commands... I just intend to rework the internals so that they all operate through a virtual grid under the hood. (That's what will allow #10 to work. Grow/shrink will modify the grid, which will cause all windows bound to it to be adjusted to match the new sizes, rather than modifying a specific window.)

@pogobanane pogobanane closed this Jul 12, 2018
@ssokolow
Copy link
Owner

Please don't close a submission just because I didn't merge it promptly. My schedule has been a mess in recent months and I'm still trying to get my hobby projects back onto the docket.

@ssokolow ssokolow reopened this Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants