This repository has been archived by the owner on Oct 21, 2024. It is now read-only.
fix: sending cookies in regional remix server with polyfills #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfredsgenkins
suggested changes
Jul 18, 2024
| const cookies = []; | ||
| for (let [key, value] of headers.entries()) { | ||
| if (key === "set-cookie") { | ||
| cookies.push(value); |
There was a problem hiding this comment.
Should not cookies be accumulated in the following format?
`${key}=${value}`
Based on this MDN example it should be.
headers.getSetCookie();
// Returns ["name1=value1", "name2=value2"]AWS appears to expect the cookies in key=value format, as seen from this example:
"cookies": [
"s_fid=7AABXMPL1AFD9BBF-0643XMPL09956DE2",
"regStatus=pre-register"
],
There was a problem hiding this comment.
so yes, but in this case the key is not the name of the cookie, but rather the key of the header. the value will contain the whole cookie header
| const cookies = []; | ||
| for (let [key, value] of headers.entries()) { | ||
| if (key === "set-cookie") { | ||
| cookies.push(value); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the fix to sending multiple cookies merged yesterday #702 does not work when remix polyfills are installed. they are missing the
getSetCookiemethod amongst a few other issues detailed here. this fixes that