Fix GetCommitteeId #503
Open
Fix GetCommitteeId #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GalRogozinski
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Note that the underlying issue stems for OperatorID being too large (64 bits)...
Since it is transferred on wire it can be 32 bits or even lower.
Having said that, we can always pad OperatorID in the future for committee hash calculations. There's no performance downside to my understanding since the padded input is still smaller than SHA's block size. It will just look a little funny and raise eyebrows.
AKorpusenko
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes a possible overflow in the
GetCommitteeIDfunction.Closes #501 .