Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eventsyncing): health calls check last seen block distance #1978

Merged
merged 21 commits into from
Jan 14, 2025
Merged

feat(eventsyncing): health calls check last seen block distance #1978

merged 21 commits into from
Jan 14, 2025

Conversation

anatolie-ssv
Copy link
Contributor

@anatolie-ssv anatolie-ssv commented Jan 9, 2025 •
edited
Loading

Enhance event syncer component to verify the distance between lastProceessedBlock time against a staleness threshold during Health checks.

@anatolie-ssv anatolie-ssv changed the base branch from main to stage January 9, 2025 17:11
anatolie-ssv and others added 3 commits January 10, 2025 11:19
@anatolie-ssv @MatusKysel
Update eth/eventsyncer/event_syncer.go
459e8f0 
Co-authored-by: Matus Kysel <MatusKysel@users.noreply.github.com>
@anatolie-ssv
typo
a2a676a
@anatolie-ssv
dedicate function to check block time
fed1713
@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 56.66667% with 13 lines in your changes missing coverage. Please review.

Project coverage is 46.7%. Comparing base (7d19f37) to head (1cb824e).
Report is 3 commits behind head on stage.

Files with missing lines Patch % Lines
eth/executionclient/execution_client.go 47.0% 9 Missing ⚠️
eth/eventsyncer/event_syncer.go 69.2% 3 Missing and 1 partial ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

anatolie-ssv and others added 4 commits January 10, 2025 09:46
@anatolie-ssv
update dedicated function to check block time
fec9401
@anatolie-ssv @MatusKysel
Update eth/eventhandler/event_handler.go
f63890e 
Co-authored-by: Matus Kysel <MatusKysel@users.noreply.github.com>
@anatolie-ssv @MatusKysel
Update eth/eventhandler/event_handler.go
393f3ec 
Co-authored-by: Matus Kysel <MatusKysel@users.noreply.github.com>
@anatolie-ssv
mock and test
a71c0ab
@anatolie-ssv anatolie-ssv mentioned this pull request Jan 10, 2025
Closed
MatusKysel
MatusKysel approved these changes Jan 11, 2025
View reviewed changes
Copy link
Contributor

@MatusKysel MatusKysel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@anatolie-ssv anatolie-ssv force-pushed the feat/eventsyncing-health branch from a58d2c9 to b3c18d3 Compare January 13, 2025 12:33
@y0sher
Copy link
Contributor

y0sher commented Jan 13, 2025

Please add some description 🙏

y0sher
y0sher reviewed Jan 13, 2025
View reviewed changes
eth/executionclient/logs.go Outdated Show resolved Hide resolved
y0sher
y0sher requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@y0sher y0sher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments

moshe-blox
moshe-blox approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@moshe-blox moshe-blox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done! 💪

@anatolie-ssv Let's make sure to sync @andrew-blox and @Roy-blox on what to look for when testing this, for example: syncing a cluster from scratch.

@anatolie-ssv anatolie-ssv merged commit 1d90a85 into stage Jan 14, 2025
7 checks passed
@anatolie-ssv anatolie-ssv deleted the feat/eventsyncing-health branch January 14, 2025 09:31
oleg-ssvlabs pushed a commit that referenced this pull request Jan 20, 2025
@anatolie-ssv @MatusKysel
@y0sher @oleg-ssvlabs
feat(eventsyncing): health calls check last seen block distance (#1978)
8ec7ebd 
Co-authored-by: Matus Kysel <matus@ssvlabs.io>
Co-authored-by: rehs0y <lyosher@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0sher y0sher y0sher approved these changes

@MatusKysel MatusKysel MatusKysel approved these changes

@moshe-blox moshe-blox moshe-blox approved these changes

@nkryuchkov nkryuchkov Awaiting requested review from nkryuchkov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anatolie-ssv @y0sher @MatusKysel @moshe-blox