Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsub): increase subscription buffer size to 256 and update go-libp2p-pubsub #1992

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

olegshmuelov
Copy link
Contributor

  1. Increase Subscription Buffer Size to 256:
    • This is a follow-up to PR #1989, where the subscription buffer size was increased to 128. That change significantly reduced message drops and improved performance.
    • However, a small number of "Can't deliver message to subscription" logs persisted during high traffic bursts. Increasing the buffer size to 256 provides additional capacity to handle message bursts more effectively and further reduces the likelihood of drops.
  2. Update go-libp2p-pubsub to v0.12.0:

@olegshmuelov olegshmuelov self-assigned this Jan 21, 2025
@olegshmuelov olegshmuelov changed the title Fix/increase subscription buffer 256 fix(pubsub): increase subscription buffer size to 256 and update go-libp2p-pubsub Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.1%. Comparing base (4e1c82f) to head (fc3b373).
Report is 2 commits behind head on stage.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@moshe-blox moshe-blox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great performance boost 💪

@olegshmuelov olegshmuelov merged commit 3e76188 into stage Jan 21, 2025
7 checks passed
@olegshmuelov olegshmuelov deleted the fix/increase-subscription-buffer-256 branch January 21, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants