Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: build-guide.md using Makefile #91

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Add: build-guide.md using Makefile #91

merged 4 commits into from
Sep 5, 2023

Conversation

itiB
Copy link
Contributor

@itiB itiB commented Aug 22, 2023

Description

Add build-guide.md for who you want to build and develop Gatling Operator form source code.
Contains how to use makefiles.

Checklist

  • Tests have been added (if applicable, ie. when operator codes are added or modified)
  • Relevant docs have been added or modified (if applicable, ie. when new features are added or current features are modified)

@itiB itiB self-assigned this Aug 22, 2023
@itiB itiB requested review from R-HNF and gold-kou August 22, 2023 11:16
@itiB itiB marked this pull request as ready for review August 22, 2023 11:16
R-HNF
R-HNF reviewed Aug 25, 2023
View reviewed changes
Copy link
Contributor

@R-HNF R-HNF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thank you.
Please check the comments!

README.md Outdated Show resolved Hide resolved
docs/build-guide.md Outdated Show resolved Hide resolved
docs/build-guide.md Outdated Show resolved Hide resolved
docs/build-guide.md Outdated Show resolved Hide resolved
@itiB
Copy link
Contributor Author

itiB commented Aug 29, 2023

@R-HNF
Thank you for your reviews.
I have read them and have completed all the necessary fixes.

@itiB itiB requested a review from R-HNF August 29, 2023 04:52
R-HNF
R-HNF approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@R-HNF R-HNF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @itiB!

@R-HNF R-HNF merged commit 6950b4c into st-tech:main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@R-HNF R-HNF R-HNF approved these changes

@gold-kou gold-kou Awaiting requested review from gold-kou

Assignees

@itiB itiB

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itiB @R-HNF