Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to get this to work. #6

Closed
wants to merge 3 commits into from
Closed

try to get this to work. #6

wants to merge 3 commits into from

Conversation

asherf
Copy link

@asherf asherf commented Apr 10, 2021

linter pass (except for an issue w/ pylint run not having access to some json file)

@cognifloyd I hope this helps!

@asherf
Copy link
Author

asherf commented Apr 10, 2021

this is just for reference, feel free to close this PR at any time.

Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. It's nice to have more people experimenting here.

@@ -49,6 +49,7 @@ inits = true

[black]
version = "black==20.8b1"
extra_requirements = ["regex>=2021.3.17"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the config we have in our internal repo... it works.... If I really think about it was probably added to override the pants default setting here, which I think is setuptools (or at least used to be) which caused issues in the past.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double checked, there is no longer a need for this (at least with recent pants versions)

Comment on lines +86 to +90
# Works around bad `-arch arm64` flag embedded in Xcode 12.x Python interpreters on intel
# machines. See: https://github.com/giampaolo/psutil/issues/1832
# On macos do: export ARCHFLAGS=-arch x86_64
# see: https://github.com/pantsbuild/pants/pull/11733
"ARCHFLAGS",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I hit this issue, I switched over to my MacPorts-installed copies of python. Good to know there's a solution :)

This won't affect any other platforms will it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this option just tells pants to pass this env variable (if defined) to subprocesses. it doesn't actually define it.
in CI, pants defines it for mac os builds, see pantsbuild/pants#11733

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and there is a thread discussion in pants slack: https://pantsbuild.slack.com/archives/C0D7TNJHL/p1617914862144100

@cognifloyd
Copy link
Member

I've got pylint running now. Hooray! Thanks for your help in here. I'll close this.

@cognifloyd cognifloyd closed this Apr 13, 2021
@asherf asherf deleted the jerry branch April 13, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants