Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the spaces before and after the question marks in the multi-line basic flashcards #719

Merged
merged 4 commits into from
Aug 13, 2023
Merged

Remove the spaces before and after the question marks in the multi-line basic flashcards #719

merged 4 commits into from
Aug 13, 2023

Conversation

matterai
Copy link
Contributor

Fixed issue mentioned here: #690.

Changes:

  • Defined currentLine variable in the beginning of the main cycle in src/parser.ts
  • Used trim() to remove the extra spaces when appending cardText
  • Used trim() to clean the line before comparing with separator symbol

@matterai matterai mentioned this pull request Aug 10, 2023
Closed
st3v3nmw
st3v3nmw requested changes Aug 13, 2023
View reviewed changes
Copy link
Owner

@st3v3nmw st3v3nmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the fix!

src/parser.ts Outdated Show resolved Hide resolved
@matterai matterai requested a review from st3v3nmw August 13, 2023 18:55
@st3v3nmw st3v3nmw merged commit 388dec9 into st3v3nmw:master Aug 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3v3nmw st3v3nmw st3v3nmw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matterai @st3v3nmw