Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved issue templates #963

Merged
merged 4 commits into from
May 25, 2024
Merged

Improved issue templates #963

merged 4 commits into from
May 25, 2024

Conversation

4Source
Copy link
Contributor

@4Source 4Source commented May 22, 2024 •
edited
Loading

I replaced the issue templates with issue forms this would make it much easier to read an gives more control what information is really required. I mostly used the original text.

GitHub docs: Replace bug_report with form instead of template

st3v3nmw
st3v3nmw approved these changes May 24, 2024
View reviewed changes
Copy link
Owner

@st3v3nmw st3v3nmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is so much better, thanks!

Please fix the linting issues

@st3v3nmw st3v3nmw merged commit ca4c261 into st3v3nmw:master May 25, 2024
1 check passed
@4Source 4Source deleted the improved_issue_templates branch May 25, 2024 08:52
KyleKlus pushed a commit to KyleKlus/obsidian-spaced-repetition that referenced this pull request Jul 22, 2024
@4Source @KyleKlus
Improved issue templates (st3v3nmw#963)
6faf597 
* Replace bug_report with form instead of template

* Replace feature_request with form instead of template

* Fix linting
KyleKlus pushed a commit to KyleKlus/obsidian-spaced-repetition that referenced this pull request Jul 22, 2024
@4Source @KyleKlus
Improved issue templates (st3v3nmw#963)
f29a8c0 
* Replace bug_report with form instead of template

* Replace feature_request with form instead of template

* Fix linting
KyleKlus added a commit to KyleKlus/obsidian-spaced-repetition that referenced this pull request Jul 22, 2024
@KyleKlus
Squashed commit of the following:
eabfb01 
commit 971e4af
Author: Anna Zubenko <anna_zubenko@fastmail.com>
Date:   Mon Jul 22 07:29:18 2024 +0200

    FEAT-990 Mobile landscape mode and functional size sliders (st3v3nmw#998)

commit a89a818
Author: 4Source <38220764+4Source@users.noreply.github.com>
Date:   Mon Jul 22 07:25:45 2024 +0200

    [FIX] Cards missing when horizontal rule present in document (st3v3nmw#970)

    * Use obsidians funtion to extractFrontmatter

    * Fix line pos shift

    * Stop using obsidian function because of UnitTest

    * Add UnitTest for Frontmatter and Horizontal line

    * Fix linting

    ---------

    Co-authored-by: Stephen Mwangi <mail@stephenmwangi.com>

commit 77f15e1
Author: Carlos Galdino <carloshsgaldino@gmail.com>
Date:   Mon Jul 22 06:02:11 2024 +0100

    Filter due notes when all are scheduled (st3v3nmw#947)

    Ignore notes due in the future.

    Fixes st3v3nmw#548

commit 83590be
Author: Newdea <9208450+Newdea@users.noreply.github.com>
Date:   Sat Jul 20 15:10:57 2024 +0800

    fix st3v3nmw#1000 sidebar indent (st3v3nmw#1001)

commit e3a0146
Author: 4Source <38220764+4Source@users.noreply.github.com>
Date:   Sat Jul 20 09:02:14 2024 +0200

    [FIX] Include link parsing for Review context (st3v3nmw#964)

    * Include link parsing

    * Fix linting

commit 3024264
Author: 4Source <38220764+4Source@users.noreply.github.com>
Date:   Sat Jul 20 09:00:46 2024 +0200

    [FIX] Not scroll back to top after review (st3v3nmw#971)

    * Update deprecated function

    * Add scroll back to top

    * Fix linting

commit 1dfd52e
Author: 4Source <38220764+4Source@users.noreply.github.com>
Date:   Sat Jul 20 09:00:33 2024 +0200

    [FIX] Folder ignore sorts all folder starting with string (st3v3nmw#972)

    * Implement isEqualOrSubPath

    * Implement UnitTest for isEqualOrSubPath

    * Replace separators with system seperator

    * Improved seperator replacement

commit b175d22
Author: artificialUsagi <41666068+artefaritaKuniklo@users.noreply.github.com>
Date:   Sat Jul 20 14:59:11 2024 +0800

    add translation: zh-cn (st3v3nmw#982)

commit ca4c261
Author: 4Source <38220764+4Source@users.noreply.github.com>
Date:   Sat May 25 10:13:50 2024 +0200

    Improved issue templates (st3v3nmw#963)

    * Replace bug_report with form instead of template

    * Replace feature_request with form instead of template

    * Fix linting

commit 053da6a
Author: 4Source <38220764+4Source@users.noreply.github.com>
Date:   Fri May 24 19:59:06 2024 +0200

    Update German localization (st3v3nmw#961)

    * Update German localization

    * Fix linting
st3v3nmw pushed a commit that referenced this pull request Sep 23, 2024
@KyleKlus
feat: extended card title (#1027)
12b3651 
* UPDATE: Extended the amount of information in the card title

* UPDATE: Improved card title in random mode

* UPDATE: Documented changes & formatted with prettier

* Squashed commit of the following:

commit 971e4af
Author: Anna Zubenko <anna_zubenko@fastmail.com>
Date:   Mon Jul 22 07:29:18 2024 +0200

    FEAT-990 Mobile landscape mode and functional size sliders (#998)

commit a89a818
Author: 4Source <38220764+4Source@users.noreply.github.com>
Date:   Mon Jul 22 07:25:45 2024 +0200

    [FIX] Cards missing when horizontal rule present in document (#970)

    * Use obsidians funtion to extractFrontmatter

    * Fix line pos shift

    * Stop using obsidian function because of UnitTest

    * Add UnitTest for Frontmatter and Horizontal line

    * Fix linting

    ---------

    Co-authored-by: Stephen Mwangi <mail@stephenmwangi.com>

commit 77f15e1
Author: Carlos Galdino <carloshsgaldino@gmail.com>
Date:   Mon Jul 22 06:02:11 2024 +0100

    Filter due notes when all are scheduled (#947)

    Ignore notes due in the future.

    Fixes #548

commit 83590be
Author: Newdea <9208450+Newdea@users.noreply.github.com>
Date:   Sat Jul 20 15:10:57 2024 +0800

    fix #1000 sidebar indent (#1001)

commit e3a0146
Author: 4Source <38220764+4Source@users.noreply.github.com>
Date:   Sat Jul 20 09:02:14 2024 +0200

    [FIX] Include link parsing for Review context (#964)

    * Include link parsing

    * Fix linting

commit 3024264
Author: 4Source <38220764+4Source@users.noreply.github.com>
Date:   Sat Jul 20 09:00:46 2024 +0200

    [FIX] Not scroll back to top after review (#971)

    * Update deprecated function

    * Add scroll back to top

    * Fix linting

commit 1dfd52e
Author: 4Source <38220764+4Source@users.noreply.github.com>
Date:   Sat Jul 20 09:00:33 2024 +0200

    [FIX] Folder ignore sorts all folder starting with string (#972)

    * Implement isEqualOrSubPath

    * Implement UnitTest for isEqualOrSubPath

    * Replace separators with system seperator

    * Improved seperator replacement

commit b175d22
Author: artificialUsagi <41666068+artefaritaKuniklo@users.noreply.github.com>
Date:   Sat Jul 20 14:59:11 2024 +0800

    add translation: zh-cn (#982)

commit ca4c261
Author: 4Source <38220764+4Source@users.noreply.github.com>
Date:   Sat May 25 10:13:50 2024 +0200

    Improved issue templates (#963)

    * Replace bug_report with form instead of template

    * Replace feature_request with form instead of template

    * Fix linting

commit 053da6a
Author: 4Source <38220764+4Source@users.noreply.github.com>
Date:   Fri May 24 19:59:06 2024 +0200

    Update German localization (#961)

    * Update German localization

    * Fix linting

* UPDATE: Quick clean up of unused code

* UPDATE: Added changelog message again

* UPDATE: Executed format script

---------

Co-authored-by: Kyle Klus <kyle.klus@f-i.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3v3nmw st3v3nmw st3v3nmw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@4Source @st3v3nmw