Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pathing #3

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Fix pathing #3

merged 1 commit into from
Aug 30, 2023

Conversation

donatj
Copy link
Collaborator

@donatj donatj commented Aug 30, 2023

So I messed up just a pinch.

The vendor directory was relative but GitHub Actions doesn’t start up from the given directory.

It worked on my machine b/c my simulation didn't change directory, but it didn't work as soon as I tried to use it with GitHub Actions 😓

This should fix it. I'm going to test it with an action before I merge it.

Once I merge it, I intend to replace the v1 tag.

The vendor directory was relative but GitHub Actions doesn’t start up the given directory.
@donatj
Copy link
Collaborator Author

donatj commented Aug 30, 2023

@donatj donatj merged commit a7dbcfc into main Aug 30, 2023
@staabm staabm deleted the fix-pathing branch August 30, 2023 10:40
@staabm
Copy link
Owner

staabm commented Aug 30, 2023

thanks

@donatj
Copy link
Collaborator Author

donatj commented Aug 30, 2023

@staabm – I retagged v1 and confirmed it to be working

https://github.com/donatj/action-test/actions/runs/6023804798/job/16341294633?pr=1

The shown errors are the expected result

image

Sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants