Improve error handling, added testcoverage #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@localheinz maybe you have an idea why the github action based sanity tests in this PR dont work? it seems the action doesnt even start.. |
localheinz
force-pushed
the
staabm-patch-1
branch
from
541f384 to
de68443
Compare
|
Looks like the workflow definition was in the wrong directory - I have merged it with I hope you don't mind me pushing into this branch! |
|
Thank you so much. |
staabm
changed the title
staabm
commented
Feb 9, 2020
| extensions: "simplexml" | ||
| php-version: "7.0" | ||
|
|
||
| - name: "Cache dependencies installed with composer" |
There was a problem hiding this comment.
deleted this unnecessary complexity, because the build is wicked fast without caching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before landing we should have some tests #5