Skip to content

Conversation

@AllenJB
Copy link
Contributor

@AllenJB AllenJB commented Oct 22, 2021

I've been setting up actions with parallel-lint.

When testing locally I see the following line in the report output from parallel-lint:

<error line="26" severity="ERROR" message="Parse error: syntax error, unexpected 'KeyValueStore' (T_STRING), expecting variable (T_VARIABLE) in App/API/Actions/Campaigns/Filter.php on line 26" source="Syntax Error" />

cs2pr sets the severity for this to "warning" instead of the expected "error" due to the case sensitive checks in annotateType()


This PR also includes a modification to .editorconfig to prevent editors from adding a newline to the end of the .expect files used by tests, causing the tests to fail.

If you want me to remove this change from this PR (and submit it separately), let me know.

Copy link
Owner

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great, thank you!

@staabm staabm merged commit c9f5024 into staabm:master Oct 22, 2021
@staabm
Copy link
Owner

staabm commented Oct 22, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants