IPF #182
Draft
IPF #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
a17
commented
Nov 14, 2024
•
a17
commented
- integration interfaces
- constants
- routes
- farms
- skeleton
- universal test
- implementation
- deploy script
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
- Coverage 97.30% 97.26% -0.05%
==========================================
Files 64 64
Lines 4641 4643 +2
Branches 514 515 +1
==========================================
Hits 4516 4516
- Misses 107 109 +2
Partials 18 18 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+90
to
+93
| function extra() external pure returns (bytes32) { | ||
| // todo | ||
| return CommonLib.bytesToBytes32(abi.encodePacked(bytes3(0x965fff), bytes3(0x000000))); | ||
| } |
Check warning
Code scanning / Slither
Too many digits Warning
Comment on lines
+251
to
+258
| function _fetchSpot( | ||
| address _tokenIn, | ||
| address _tokenOut, | ||
| int _tick, | ||
| uint _amountIn | ||
| ) internal pure returns (uint amountOut) { | ||
| // return IQMFLib.getQuoteAtTick(int24(_tick), SafeCast.toUint128(_amountIn), _tokenIn, _tokenOut); | ||
| } |
Check warning
Code scanning / Slither
Dead-code Warning
Comment on lines
+269
to
+284
| function _fetchTwap( | ||
| address _pool, | ||
| address _tokenIn, | ||
| address _tokenOut, | ||
| uint32 _twapPeriod, | ||
| uint _amountIn | ||
| ) internal view returns (uint amountOut) { | ||
| // Leave twapTick as a int256 to avoid solidity casting | ||
| /*int twapTick = IQMFLib.consult(_pool, _twapPeriod); | ||
| return IQMFLib.getQuoteAtTick( | ||
| int24(twapTick), // can assume safe being result from consult() | ||
| SafeCast.toUint128(_amountIn), | ||
| _tokenIn, | ||
| _tokenOut | ||
| );*/ | ||
| } |
Check warning
Code scanning / Slither
Dead-code Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.